Skip to content

Conversation

@alessfg
Copy link
Member

@alessfg alessfg commented Jun 26, 2025

Proposed changes

Update mainline NGINX to 1.29.0, NJS to 0.9.0, and mainline Alpine Linux to 3.22.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have run the update.sh script and ensured all entrypoint/Dockerfile template changes have been applied to the relevant image entrypoint scripts & Dockerfiles
  • I have tested that the NGINX Docker unprivileged image builds and runs correctly on all supported architectures on an unprivileged environment (check out the README for more details)
  • I have updated any relevant documentation (README.md)

* And NJS to 0.9.0
* And mainline Alpine Linux to 3.22
Copilot AI review requested due to automatic review settings June 26, 2025 11:37
@alessfg alessfg requested a review from a team as a code owner June 26, 2025 11:37
@alessfg alessfg self-assigned this Jun 26, 2025
@alessfg alessfg added the enhancement New feature or request label Jun 26, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the mainline NGINX image versions, along with NJS, Alpine Linux, and related checksum values used across various Dockerfiles and the update script. Key changes include:

  • Updating version numbers and corresponding pkgosschecksum values in multiple Dockerfiles.
  • Replacing the usage of "greadlink" with "readlink" and "gsed" with "sed" in update.sh.
  • Adjusting architecture documentation in README.md.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
update.sh Updated version values, removed greadlink in favor of readlink, and updated sed usage.
mainline/debian/Dockerfile Updated NGINX and NJS version and checksum values.
mainline/debian-perl/Dockerfile Updated image version and checksum values.
mainline/debian-otel/Dockerfile Updated image version and checksum values.
mainline/alpine/Dockerfile Updated image, NJS version, and checksum values.
mainline/alpine-slim/Dockerfile Updated Alpine image and NGINX version, with corresponding checksum update.
mainline/alpine-perl/Dockerfile Updated image version and checksum values.
mainline/alpine-otel/Dockerfile Updated image version and checksum values.
README.md Updated the list of supported architectures and added note on OTEL images.
Comments suppressed due to low confidence (1)

update.sh:5

  • [nitpick] Verify that replacing 'greadlink' with 'readlink' does not alter behavior on environments where GNU readlink features are expected, especially on non-Linux systems.
cd "$(dirname "$(readlink -f "$BASH_SOURCE")")"

@alessfg alessfg enabled auto-merge (squash) June 27, 2025 12:28
@alessfg
Copy link
Member Author

alessfg commented Jun 27, 2025

The build is failing due to how the pipeline works. Since the first builds in the sequence did succeed, the rest should work too once the images are actually pushed.

@alessfg alessfg merged commit 22cffb6 into main Jun 27, 2025
16 of 19 checks passed
@alessfg alessfg deleted the update branch June 27, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants