Skip to content

Commit a387b34

Browse files
committed
fix: fixing review comments
1 parent c180ed6 commit a387b34

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

static/scripts/install-nim-bundle.sh

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -118,14 +118,14 @@ fi
118118
createNginxMgmtFile(){
119119
# Check if the mgmt block exists in the file
120120
if grep -Eq '^[[:space:]]*mgmt' "/etc/nginx/nginx.conf"; then
121-
printf "nginx management found, skipping adding nginx mgmt block"
121+
printf "Nginx 'mgmt' block found, skipping addition of nginx 'mgmt' block"
122122
elif grep -Eq '^[[:space:]]*#mgmt' "/etc/nginx/nginx.conf"; then
123-
printf "nginx management block disabled, enabling mgmt block"
123+
printf "Nginx 'mgmt' block disabled, enabling 'mgmt' block"
124124
sed -i '/#mgmt {/,/#}/d' /etc/nginx/nginx.conf
125125
# shellcheck disable=SC2059
126126
printf "${NMS_NGINX_MGMT_BLOCK}" | tee -a /etc/nginx/nginx.conf
127127
else
128-
printf "nginx management block not found, adding mgmt block"
128+
printf "Nginx 'mgmt' block not found, adding 'mgmt' block"
129129
# shellcheck disable=SC2059
130130
printf "${NMS_NGINX_MGMT_BLOCK}" | tee -a /etc/nginx/nginx.conf
131131
fi
@@ -340,7 +340,7 @@ installBundleForDebianDistro() {
340340
nim_major_version=$(nms-core --version | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | awk -F. '{print $1}')
341341
nim_minor_version=$(nms-core --version | grep -oE '[0-9]+\.[0-9]+\.[0-9]+' | awk -F. '{print $1}')
342342
if [[ $nim_major_version -ge 2 && $nim_minor_version -ge 19 ]]; then
343-
echo "Warning: NIM version >=2.19.0 comes with security module installed already. skipping installing security module"
343+
echo "Note: NGINX Instance Manager version 2.19.0 or later comes with security monitoring installed. skipping installing security monitoring"
344344
else
345345
printf "Installing security module...\n"
346346
if [ "${NIM_SM_VERSION}" == "latest" ]; then
@@ -538,15 +538,14 @@ printSupportedOS(){
538538
printf "\n ubuntu20.04(focal)"
539539
printf "\n ubuntu22.04(jammy)"
540540
printf "\n ubuntu24.04(noble)"
541-
printf "\n debian11"
542-
printf "\n debian12"
543-
printf "\n centos8(Cent OS 8)"
541+
printf "\n debian11(bullseye)"
542+
printf "\n debian12(bookworm)"
543+
printf "\n centos8(CentOS 8)"
544544
printf "\n rhel8(Redhat Enterprise Linux Version 8)"
545545
printf "\n rhel9( Redhat Enterprise Linux Version 9)"
546546
printf "\n oracle7(Oracle Linux Version 7)"
547547
printf "\n oracle8(Oracle Linux Version 8)"
548548
printf "\n amzn2(Amazon Linux 2)"
549-
printf "\n "
550549
exit 0
551550
}
552551

0 commit comments

Comments
 (0)