You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/pull_request_template.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -26,10 +26,10 @@ Before merging a pull request, run through this checklist and mark each as compl
26
26
-[ ] I have rebased my branch onto main
27
27
-[ ] I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
28
28
-[ ] I have ensured that the commit messages adhere to [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/#summary)
29
-
-[ ] I have ensured that documentation content adheres to [the style guide](https://github.com/nginx/documentation/blob/main/templates/style-guide.md)
29
+
-[ ] I have ensured that documentation content adheres to [the style guide](/documentation/style-guide.md)
30
30
-[ ] If the change involves potentially sensitive changes[^1], I have assessed the possible impact
31
31
-[ ] If applicable, I have added tests that prove my fix is effective or that my feature works
32
32
-[ ] I have ensured that existing tests pass after adding my changes
33
-
-[ ] If applicable, I have updated [`README.md`](https://github.com/nginx/documentation/blob/main/README.md) and [`CHANGELOG.md`](https://github.com/nginx/documentation/blob/main/CHANGELOG.md)
33
+
-[ ] If applicable, I have updated [`README.md`](/README.md)
34
34
35
-
[^1]: Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to [our style guide](https://github.com/nginx/documentation/blob/main/templates/style-guide.md) for guidance about placeholder content.
35
+
[^1]: Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to [our style guide](/documentation/style-guide.md) for guidance about placeholder content.
- An enhancement is an improvement of some kind, such as a new document or additional detail for a product feature
23
+
- A bug report draws attention to an issue in documentation, such as an incorrect command or outdated information
39
24
40
-
## Submit a Pull Request
25
+
Before creating an issue, please check there is [no existing issue](https://github.com/nginx/documentation/issues?q=is%3Aissue) for the topic.
41
26
42
-
To contribute to F5 NGINX documentation, follow these steps:
43
-
44
-
- Fork the NGINX repository
45
-
- Create a branch
46
-
- Implement your changes in your branch
47
-
- Submit a pull request (PR) when your changes are ready for review
27
+
We encourage discussions within issues, since they act as a source of contextual truth and are linked to pull requests.
48
28
49
-
Alternatively, you're welcome to suggest improvements to highlight problems with
50
-
our documentation as described in our [support](./SUPPORT.md) page.
29
+
## Start a discussion
51
30
52
-
### Git style guide
31
+
We encourage you to use [GitHub Discussions](https://github.com/nginx/documentation/discussions) for conversations with the community and maintainers.
53
32
54
-
- Keep a clean, concise and meaningful Git commit history on your branch, rebasing locally and squashing before you submit a PR
55
-
- We use [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/#summary) formatting.
56
-
- Follow the guidelines of writing a good commit message as described here <https://chris.beams.io/posts/git-commit/>
57
-
and summarized in the next few points:
33
+
If you'd like to discuss something NGINX-related that doesn't involve documentation, you should go to the [NGINX Community Forum](https://community.nginx.org/).
58
34
59
-
- In the subject line, use the present tense ("Add feature" not "Added feature")
60
-
- In the subject line, use the imperative mood ("Move cursor to..." not "Moves cursor to...")
61
-
- Limit the subject line to 72 characters or less
62
-
- Reference issues and pull requests liberally after the subject line
63
-
- Add more detailed description in the body of the git message (`git commit -a` to give you more space and time in
64
-
your text editor to write a good message instead of `git commit -am`)
35
+
## Submit a pull request
65
36
66
-
#### Branch protection rules
37
+
Before making documentation changes, you should view the [documentation style guide](/documentation/style-guide.md) and [Managing content with Hugo](/documentation/writing-hugo.md).
67
38
68
-
This repository has the following branch protection rules in place:
39
+
To understand how we use Git in this repository, read our [Git conventions](/documentation/git-conventions.md) documentation.
69
40
70
-
-**Pushing branches that contain the "internal/" prefix is not allowed.** This ensures internal development branches are not accidentally or purposefully pushed to this repo.
71
-
-**Two approvers are required for all merges to main and release branches.** This ensures all code that is approved for release to production is appropriately reviewed. This rule applies to all branches with `*release*` in the branch name.
72
-
-**Only NGINX DocOps Team members can create release branches.** This ensures the docs team is aware of all branches supporting specific product releases. This rule applies to all branches with `*release*` in the branch name.
73
-
-**Pushes (force or otherwise) directly to main or release branches is not allowed.** Release branches serve as "main" for the release they are associated with. Restricting pushes directly to main and release branches ensures all content changes are reviewed and approved. This rule applies to all branches with `*release*` in the branch name and to "main".
41
+
The broad workflow is as follows:
74
42
75
-
### Documentation style guide
43
+
- Fork the NGINX repository
44
+
- Create a branch
45
+
- Implement your changes in your branch
46
+
- Submit a pull request (PR) when your changes are ready for review
76
47
77
-
For detailed guidance, see our documentation [style guide](./templates/style-guide.md).
48
+
Alternatively, you're welcome to suggest improvements to highlight problems with our documentation as described in our [support](./SUPPORT.md) page.
78
49
79
50
## Issue lifecycle
80
51
@@ -93,7 +64,6 @@ This repository does not include all of the source content for the NGINX documen
93
64
-[NGINX Open Source](https://github.com/nginx/nginx) - source for [NGINX changelog](https://nginx.org/en/CHANGES)
94
65
-[nginx.org](https://github.com/nginx/nginx.org) - source for https://nginx.org
95
66
-[NGINX Unit](https://github.com/nginx/unit) - source for https://unit.nginx.org
96
-
-[NGINX Ingress Controller](https://github.com/nginxinc/kubernetes-ingress/) - source for https://docs.nginx.com/nginx-ingress-controller
97
67
98
68
In those repositories, you can find documentation source code in the `docs` or `site` subdirectories.
<!-- These are the "repo [status badge](https://www.repostatus.org/)s" and the community support badges -->
8
-
9
7
# NGINX documentation
10
8
9
+
This repository contains the user documentation for NGINX's products, as well as the requirements to build and publish the documentation website.
10
+
11
+
Documentation is written in [Markdown](https://daringfireball.net/projects/markdown/basics), then transformed into HTML using the [Hugo](https://gohugo.io/) static site generator.
12
+
11
13
If you want to contribute to [F5 NGINX documentation](https://docs.nginx.com), you've come to the right place. We've organized a series of README-type files to help you get started:
12
14
13
15
-[Contributing](/CONTRIBUTING.md) describes how you can contribute to our documentation.
14
-
-[Contributing guidelines for experts](/CONTRIBUTING_DOCS.md) describes how you can contribute (and check your work) with Hugo, our static site generator
15
16
-[Code of Conduct](/CODE_OF_CONDUCT.md) describes expectations in the NGINX open source community.
16
17
-[License](/LICENSE) shows the license associated with work on this repository.
17
18
-[Security](/SECURITY.md) describes the procedures we would like you to follow if you find a security issue.
18
19
-[Support](/SUPPORT.md) lists how you can get support as a customer or a community member.
19
20
20
-
## Explanation
21
-
22
-
This repository contains user documentation for NGINX's products, as well as the requirements for linting, building, and publishing the documentation.
23
-
24
-
Our documentation is written in Markdown, specifically the [Goldmark](https://github.com/yuin/goldmark) Markdown parser.
25
-
We build our docs using [Hugo](https://gohugo.io) and host them in custom URLs on Azure.
21
+
You may also find the [documentation folder](/documentation/) for the repository interesting: it's where we store our process information.
0 commit comments