Skip to content

Conversation

bejjrajesh
Copy link
Contributor

Proposed changes

This MR contains below two changes

  1. It will send a request to pkgs.nginx.com for tracking how many online/offline installs are done using the script.
  2. It will support generating the fqdn name for generating nim certificates.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md and CHANGELOG.md)
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.

Please refer to our style guide for guidance about placeholder content.

@bejjrajesh bejjrajesh requested a review from a team as a code owner February 6, 2025 10:26
@mjang mjang self-requested a review February 6, 2025 16:37
@mjang
Copy link
Contributor

mjang commented Feb 6, 2025

Approval / merge pending testing (WiP)

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on review of developer test.

@mjang mjang merged commit 36ee197 into nginx:main Feb 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants