Skip to content

Conversation

@mkingst
Copy link
Contributor

@mkingst mkingst commented Jan 2, 2025

Proposed changes

Updated tech specs to account for this issue:

https://github.com/nginxinc/docs/issues/1528

Problem: Give a brief overview of the problem or feature being addressed.

Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.

Testing: Describe any testing that you did.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

@mkingst mkingst requested a review from a team as a code owner January 2, 2025 15:21
@github-actions
Copy link

github-actions bot commented Jan 2, 2025

🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree:


I have hereby read the F5 CLA and agree to its terms


1 out of 2 committers have signed the CLA.
✅ (mjang)[https://github.com/mjang]
@mkingst
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@mkingst
Copy link
Contributor Author

mkingst commented Jan 2, 2025 via email

@mjang
Copy link
Contributor

mjang commented Jan 2, 2025

recheck

@mjang mjang self-requested a review January 2, 2025 16:51
{{<bootstrap-table "table table-striped table-bordered">}}
| Number of Data Plane Instances | CPU | Memory | Network | Storage |
|--------------------------------|--------|----------|-----------|---------|
| n/a | 2 vCPU | 4 GB RAM | 1 GbE NIC | 20 GB |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We successfully tested 50k instances "reporting" to NIM in an unmanaged way with this spec without issue.

@mjang
Copy link
Contributor

mjang commented Jan 2, 2025

The original PR added a section called "Sizing recommendations for License and Usage Reporting Only"

I think this belongs as a subsection of http://docs.nginx.com/nginx-instance-manager/fundamentals/tech-specs/#system-sizing, and have included a link to the "Prepare your environment" section of https://docs.nginx.com/solutions/about-subscription-licenses/#set-up-environment. Here's how my suggested change appears in the build. (@mkingst WDYT?) (I've also reorganized the data into tables compatible with previous sections.)

Screenshot 2025-01-02 at 8 56 35 AM

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

## Sizing recommendations {#system-sizing}
## Sizing recommendations for License and Usage Reporting Only {#reporting-sizing}

This page assumes NGINX instances are being “managed” by NGINX Instance Manager. The sizing requirements are significantly less if you are just using NGINX Instance Manager for licensing and usage reporting only. NGINX commercial license and usage reporting is done in an “unmanaged” way, where NGINX simply sends a request periodically to NGINX Instance Manager for counting purposes. See the [Report Usage](https://docs.nginx.com/nginx-instance-manager/disconnected/report-usage-disconnected-deployment/) guide.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This page assumes NGINX instances are being “managed” by NGINX Instance Manager. The sizing requirements are significantly less if you are just using NGINX Instance Manager for licensing and usage reporting only. NGINX commercial license and usage reporting is done in an “unmanaged” way, where NGINX simply sends a request periodically to NGINX Instance Manager for counting purposes. See the [Report Usage](https://docs.nginx.com/nginx-instance-manager/disconnected/report-usage-disconnected-deployment/) guide.
This section assumes you've configured NGINX Instance Manager to manage your NGINX instances, for licensing and usage reporting only. NGINX commercial license and usage reporting is done in an “unmanaged” way, where NGINX sends a request periodically to NGINX Instance Manager solely for counting purposes. See the [Report Usage]({{< relref "/solutions/about-subscription-licenses.md#set-up-environment" >}}) guide.

@mjang
Copy link
Contributor

mjang commented Jan 2, 2025

I have hereby read the F5 CLA and agree to its terms

@mjang
Copy link
Contributor

mjang commented Jan 2, 2025

recheck

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed with @mkingst

Copy link
Contributor Author

@mkingst mkingst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@mjang mjang merged commit 3e99d18 into main Jan 3, 2025
3 of 5 checks passed

### License and usage reporting only {#reporting-sizing}

This section assumes you've configured NGINX Instance Manager to manage your NGINX instances for licensing and usage reporting only. NGINX commercial license and usage reporting is done in an “unmanaged” way, where NGINX sends a request periodically to NGINX Instance Manager solely for counting purposes. For more information, see how you would [Prepare your environment for reporting]({{< relref "/solutions/about-subscription-licenses.md#set-up-environment" >}}).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest adding "Plus" as it's Plus-only feature ("NGINX Plus instances", "NGINX Plus commercial license and usage reporting")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this also apply to NIM?

If we're specifying licensed products, would we say "NGINX Plus and NGINX Instance Manager instances..."

  • Or is the reference to licensing in this paragraph enough?

@mjang mjang deleted the mkingst-tech-specs-update-for-ev branch January 7, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants