-
Notifications
You must be signed in to change notification settings - Fork 121
Update tech-specs.md for ev reporting #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree: I have hereby read the F5 CLA and agree to its terms 1 out of 2 committers have signed the CLA. |
|
I have hereby read the F5 CLA and agree to its terms
…________________________________
From: github-actions[bot] ***@***.***>
Sent: Thursday 2 January 2025 15:22
To: nginx/documentation ***@***.***>
Cc: Micheal Kingston ***@***.***>; Author ***@***.***>
Subject: Re: [nginx/documentation] Update tech-specs.md for ev reporting (PR #35)
🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA)<https://github.com/f5/.github/blob/main/CLA/cla-markdown.md>, which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA<https://github.com/f5/.github/blob/main/CLA/cla-markdown.md> and reply on a new comment with the following text to agree:
________________________________
I have hereby read the F5 CLA and agree to its terms
________________________________
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.
—
Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKTJQU7GL7XYOLBSEE2IJ6L2IVKTBAVCNFSM6AAAAABUQEOG6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRXHEZTSNJSGA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
recheck |
| {{<bootstrap-table "table table-striped table-bordered">}} | ||
| | Number of Data Plane Instances | CPU | Memory | Network | Storage | | ||
| |--------------------------------|--------|----------|-----------|---------| | ||
| | n/a | 2 vCPU | 4 GB RAM | 1 GbE NIC | 20 GB | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We successfully tested 50k instances "reporting" to NIM in an unmanaged way with this spec without issue.
|
The original PR added a section called "Sizing recommendations for License and Usage Reporting Only" I think this belongs as a subsection of http://docs.nginx.com/nginx-instance-manager/fundamentals/tech-specs/#system-sizing, and have included a link to the "Prepare your environment" section of https://docs.nginx.com/solutions/about-subscription-licenses/#set-up-environment. Here's how my suggested change appears in the build. (@mkingst WDYT?) (I've also reorganized the data into tables compatible with previous sections.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #35 (comment)
| ## Sizing recommendations {#system-sizing} | ||
| ## Sizing recommendations for License and Usage Reporting Only {#reporting-sizing} | ||
|
|
||
| This page assumes NGINX instances are being “managed” by NGINX Instance Manager. The sizing requirements are significantly less if you are just using NGINX Instance Manager for licensing and usage reporting only. NGINX commercial license and usage reporting is done in an “unmanaged” way, where NGINX simply sends a request periodically to NGINX Instance Manager for counting purposes. See the [Report Usage](https://docs.nginx.com/nginx-instance-manager/disconnected/report-usage-disconnected-deployment/) guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This page assumes NGINX instances are being “managed” by NGINX Instance Manager. The sizing requirements are significantly less if you are just using NGINX Instance Manager for licensing and usage reporting only. NGINX commercial license and usage reporting is done in an “unmanaged” way, where NGINX simply sends a request periodically to NGINX Instance Manager for counting purposes. See the [Report Usage](https://docs.nginx.com/nginx-instance-manager/disconnected/report-usage-disconnected-deployment/) guide. | |
| This section assumes you've configured NGINX Instance Manager to manage your NGINX instances, for licensing and usage reporting only. NGINX commercial license and usage reporting is done in an “unmanaged” way, where NGINX sends a request periodically to NGINX Instance Manager solely for counting purposes. See the [Report Usage]({{< relref "/solutions/about-subscription-licenses.md#set-up-environment" >}}) guide. |
|
I have hereby read the F5 CLA and agree to its terms |
|
recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As agreed with @mkingst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
|
|
||
| ### License and usage reporting only {#reporting-sizing} | ||
|
|
||
| This section assumes you've configured NGINX Instance Manager to manage your NGINX instances for licensing and usage reporting only. NGINX commercial license and usage reporting is done in an “unmanaged” way, where NGINX sends a request periodically to NGINX Instance Manager solely for counting purposes. For more information, see how you would [Prepare your environment for reporting]({{< relref "/solutions/about-subscription-licenses.md#set-up-environment" >}}). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest adding "Plus" as it's Plus-only feature ("NGINX Plus instances", "NGINX Plus commercial license and usage reporting")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this also apply to NIM?
If we're specifying licensed products, would we say "NGINX Plus and NGINX Instance Manager instances..."
- Or is the reference to licensing in this paragraph enough?

Proposed changes
Updated tech specs to account for this issue:
https://github.com/nginxinc/docs/issues/1528
Problem: Give a brief overview of the problem or feature being addressed.
Solution: Explain the approach you took to implement the solution, highlighting any significant design decisions or
considerations.
Testing: Describe any testing that you did.
Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
If this PR addresses an issue on GitHub, ensure that you link to it here:
Closes #ISSUE
Checklist
Before creating a PR, run through this checklist and mark each as complete.
I have read the contributing guidelines
I have signed the F5 Contributor License Agreement (CLA)
If applicable, I have added tests that prove my fix is effective or that my feature works
If applicable, I have checked that any relevant tests pass after adding my changes
I have updated any relevant documentation (
README.mdandCHANGELOG.md)I have rebased my branch onto main
I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
If the change involves:
<username>in place of PIIIn these cases, the change will require at least two (2) approvals before merging