Skip to content

Conversation

@Dindihub
Copy link

@Dindihub Dindihub commented Apr 30, 2025

Proposed changes

Problem: I updated the Tarball extension from .tgz to tar.gz in markdown files in the content folder

Solution: Searched for .tgz mentions in markdown and replaced with tar.gz as indicated in the issue by @mjang

Testing: I ran the Hugo server locally using make watch to ensure my project works properly

Please focus on (optional): .tgz change to .tar.gz in /content markdown files

Note: I ran make link-markdown and make link-check, but neither passed. I left it as is because they highlighted format issues beyond what my PR addresses. For example, there are issues with blockquote, dead links, e.t.c. But with your permission, I can work on them in another PR

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes #446

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

@Dindihub Dindihub requested a review from a team as a code owner April 30, 2025 09:33
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nim Issues related to NGINX Instance Manager product/nginxaas-azure Issues related to NGINX as a Service for Azure tooling Back end, repository, Hugo, and all things not related to content product/controller Issues related to NGINX Controller (EOS product) product/dos Issues related to F5 DoS for NGINX product/waf Issues related to F5 WAF for NGINX product/nms Issues related to NGINX Management Suite (EOS product) labels Apr 30, 2025
@github-actions
Copy link

github-actions bot commented Apr 30, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@Dindihub
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

@Dindihub Dindihub changed the title Update Tarball extension from .tgz to tar.gz in markdown files docs: update tarball extension from .tgz to tar.gz in markdown files Apr 30, 2025
@ADubhlaoich
Copy link
Member

Note: I ran make link-markdown and make link-check, but neither passed. I left it as is because they highlighted format issues beyond what my PR addresses. For example, there are issues with blockquote, dead links, e.t.c. But with your permission, I can work on them in another PR

I wouldn't worry about this too much: they haven't been a mandatory part of PR work for a while and are due a revisit.

Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tarball changes LGTM but adding a full copy of the Hugo binaries is out of scope for the PR or the original issue.

Copy link
Contributor

@JTorreG JTorreG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the changes to the makefile and the bin folder from this PR.

@Dindihub
Copy link
Author

The tarball changes LGTM but adding a full copy of the Hugo binaries is out of scope for the PR or the original issue.

You are right. Let me rebase. Thanks

@Dindihub Dindihub force-pushed the tarball-extension branch from e726069 to f719d79 Compare April 30, 2025 10:39
@Dindihub
Copy link
Author

The tarball changes LGTM but adding a full copy of the Hugo binaries is out of scope for the PR or the original issue.

Done @ADubhlaoich @JTorreG Please review. Thanks

@mjang mjang requested review from ADubhlaoich and JTorreG May 2, 2025 15:01
@mjang
Copy link
Contributor

mjang commented Jun 30, 2025

@Dindihub . Thank you so much for your contribution. While I thought I had a commitment to standardize our tarball file extensions with .tar.gz, it's not happening in practice.

I thank you for your work on this PR. We may be able to revive it later. But for now, I'm going to close this without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/controller Issues related to NGINX Controller (EOS product) product/dos Issues related to F5 DoS for NGINX product/nginxaas-azure Issues related to NGINX as a Service for Azure product/nim Issues related to NGINX Instance Manager product/nms Issues related to NGINX Management Suite (EOS product) product/waf Issues related to F5 WAF for NGINX tooling Back end, repository, Hugo, and all things not related to content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update all gzip-compressed tarballs to have a tar.gz extension

4 participants