Skip to content

Conversation

@ohad-perets
Copy link
Contributor

alpine 3.19 doc

Proposed changes

adding doc for alpine 3.19(identical to other alpine OS)

Testing: preview & team review

If this PR addresses an issue on GitHub, ensure that you link to it here:

Closes https://jira.f5net.com/browse/WAFMC-9431

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • [] I have read the contributing guidelines
  • [] I have signed the F5 Contributor License Agreement (CLA)
  • [] I have ensured that documentation content adheres to the style guide
  • [] If the change involves potentially sensitive changes, I have assessed the possible impact
  • [] If applicable, I have added tests that prove my fix is effective or that my feature works
  • [] If applicable, I have checked that any relevant tests pass after adding my changes
  • [] I have updated any relevant documentation (README.md and CHANGELOG.md)
  • [] I have rebased my branch onto main
  • [] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.

Please refer to our style guide for guidance about placeholder content.

nginx-aoife and others added 7 commits January 21, 2025 09:05
* Update deploy-with-kic.md

* Update deploy-with-kic.md

---------

Co-authored-by: Alan Dooley <[email protected]>
* feat: Update pull request template

This commit fixes the spacing issue of the pull request checklist by
changing the final checklist item. The relevant information now exists
as a sentence after the list, as well as an additional line.

The additional line, alongside a similar one added to the checklist,
direct the reader to our style guide to review specific guidance that
would otherwise be too verbose to add to the template.
* linkchecker update ignore list

* update links to kic docs
With the newly open source documentation repository, we can now
consolidate all NGINX documentation into one place. This has a lots of
benefits which include but are not limited to more effective content
re-use, pipeline engineering and style enforcement.

This commit adds all of the content for NGINX Gateway Fabric, and
updates all relevant folder and file names, including link references.
Once this content has been successfully deployed, a PR to remove all
documentation traces and tooling will be opened in the Gateway Fabric
repository, decoupling the documentation fully.

It also updates the frontmatter of every single page in the 
documentation set. They are now all consistent in their fields and 
formatting, and a handful of IA or heading changes have 
been made as low-hanging fruit to bring the documentation 
set closer to full consistency.
@ohad-perets ohad-perets self-assigned this Jan 23, 2025
@ohad-perets ohad-perets requested a review from a team as a code owner January 23, 2025 19:04
@github-actions
Copy link

github-actions bot commented Jan 23, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@github-actions
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/93/

@mjang
Copy link
Contributor

mjang commented Jan 24, 2025

recheck

@ADubhlaoich
Copy link
Member

@ohad-perets This is the incorrect branch for the change: please change your target to nap-release-5.5

@ohad-perets ohad-perets changed the base branch from main to nap-release-5.5 January 26, 2025 16:14
@ohad-perets ohad-perets requested a review from a team as a code owner January 26, 2025 16:14
@ohad-perets
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@ohad-perets
Copy link
Contributor Author

recheck

@ohad-perets
Copy link
Contributor Author

@ohad-perets This is the incorrect branch for the change: please change your target to nap-release-5.5

but we need the changes for both, 4.13 & 5.5 why do we need 2 separate branches?

@ADubhlaoich
Copy link
Member

@ohad-perets This is the incorrect branch for the change: please change your target to nap-release-5.5

but we need the changes for both, 4.13 & 5.5 why do we need 2 separate branches?

There might have been separate changes for each individual release: there is a release branch for each individual product's versions.

If NAP releases are always going to be tied together despite separate versioning, we'll just use a single one going forward.

@ohad-perets
Copy link
Contributor Author

new PR will be sent shortly

@mjang mjang deleted the ohad-perets-patch-1 branch March 5, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants