Skip to content

Commit 3782b4d

Browse files
committed
Lint/Update text in CRDS
1 parent e298e1f commit 3782b4d

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

config/crd/bases/k8s.nginx.org_virtualservers.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ spec:
9898
recordType:
9999
type: string
100100
targets:
101-
description: Targets stores an optional list of specified targets
101+
description: Targets stores a list of specified targets
102102
items:
103103
type: string
104104
type: array

deploy/crds.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1416,7 +1416,7 @@ spec:
14161416
recordType:
14171417
type: string
14181418
targets:
1419-
description: Targets stores an optional list of specified targets
1419+
description: Targets stores a list of specified targets
14201420
items:
14211421
type: string
14221422
type: array

internal/externaldns/sync.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ func getValidTargets(endpoints []vsapi.ExternalEndpoint, chosenTargets extdnsapi
124124
}
125125
}
126126

127-
//priority: prefer IPv4 > IPv6 > CNAME
127+
// priority: prefer IPv4 > IPv6 > CNAME
128128
if len(ipv4Targets) > 0 {
129129
if err := externaldns_validation.IsUnique(ipv4Targets); err != nil {
130130
return nil, "", err
@@ -141,7 +141,7 @@ func getValidTargets(endpoints []vsapi.ExternalEndpoint, chosenTargets extdnsapi
141141
}
142142
for _, h := range cnameTargets {
143143
if err := externaldns_validation.IsFullyQualifiedDomainName(h); err != nil {
144-
return nil, "", fmt.Errorf("%w: target %q is invalid: %v", externaldns_validation.ErrTypeInvalid, h, err)
144+
return nil, "", fmt.Errorf("%w: target %q is invalid: %w", externaldns_validation.ErrTypeInvalid, h, err)
145145
}
146146
}
147147
return cnameTargets, "CNAME", nil

pkg/apis/externaldns/validation/externaldns.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ func ValidateTargetsAndDetermineRecordType(targets []string) ([]string, string,
2727
}
2828
} else {
2929
if err := IsFullyQualifiedDomainName(t); err != nil {
30-
return nil, "", fmt.Errorf("%w: target %q is invalid: %v", ErrTypeInvalid, t, err)
30+
return nil, "", fmt.Errorf("%w: target %q is invalid: %w", ErrTypeInvalid, t, err)
3131
}
3232
recordCNAME = true
3333
}

0 commit comments

Comments
 (0)