add license_reporting_test.go

Author: Jim Ryan

internal/configs/version1/nginx-plus.tmpl

@@ -360,7 +360,7 @@ stream {
 
 {{- if .NginxVersion.PlusGreaterThanOrEqualTo "nginx-plus-r33" }}
 mgmt {
-    usage_report endpoint=product.connect.nginx.com interval=30m;
+    usage_report endpoint=product.connect.nginx.com interval=24h;
     uuid_file /var/lib/nginx/nginx.id;
     license_token conf/license.jwt;
     deployment_ctx /etc/nginx/reporting/tracking.info;

internal/license_reporting/license_reporting.go

@@ -39,8 +39,8 @@ func writeLicenseInfo(info *licenseInfo) {
 	jsonData, err := json.Marshal(info)
 	if err != nil {
 		glog.Errorf("failed to marshal LicenseInfo to JSON: %v", err)
+		return
 	}
-
 	filePath := filepath.Join(reportingDir, reportingFile)
 	if err := os.WriteFile(filePath, jsonData, 0o600); err != nil {
 		glog.Errorf("failed to write license reporting info to file: %v", err)
@@ -76,17 +76,14 @@ func (lr *LicenseReporter) collectAndWrite(ctx context.Context) {
 	if err != nil {
 		glog.Errorf("Error collecting ClusterIDS: %v", err)
 	}
-
 	nodeCount, err := clusterInfo.GetNodeCount(ctx, lr.config.K8sClientReader)
 	if err != nil {
 		glog.Errorf("Error collecting ClusterNodeCount: %v", err)
 	}
-
 	installationID, err := clusterInfo.GetInstallationID(ctx, lr.config.K8sClientReader, lr.config.PodNSName)
 	if err != nil {
 		glog.Errorf("Error collecting InstallationID: %v", err)
 	}
-
 	info := newLicenseInfo(clusterID, installationID, nodeCount)
 	writeLicenseInfo(info)
 }

internal/license_reporting/license_reporting_test.go

@@ -0,0 +1,76 @@
+package licensereporting
+
+import (
+	"encoding/json"
+	"os"
+	"path/filepath"
+	"testing"
+	"time"
+
+	"k8s.io/apimachinery/pkg/types"
+	"k8s.io/client-go/kubernetes/fake"
+)
+
+func TestNewLicenseInfo(t *testing.T) {
+	info := newLicenseInfo("test-cluster", "test-installation", 5)
+
+	if info.Integration != "nic" {
+		t.Errorf("newLicenseInfo() Integration = %v, want %v", info.Integration, "nic")
+	}
+	if info.ClusterID != "test-cluster" {
+		t.Errorf("newLicenseInfo() ClusterID = %v, want %v", info.ClusterID, "test-cluster")
+	}
+	if info.InstallationID != "test-installation" {
+		t.Errorf("newLicenseInfo() InstallationID = %v, want %v", info.InstallationID, "test-installation")
+	}
+	if info.ClusterNodeCount != 5 {
+		t.Errorf("newLicenseInfo() ClusterNodeCount = %v, want %v", info.ClusterNodeCount, 5)
+	}
+}
+
+func TestWriteLicenseInfo(t *testing.T) {
+	tempDir := t.TempDir()
+	oldReportingDir := reportingDir
+	reportingDir = tempDir
+	defer func() { reportingDir = oldReportingDir }()
+
+	info := newLicenseInfo("test-cluster", "test-installation", 5)
+	writeLicenseInfo(info)
+
+	filePath := filepath.Join(tempDir, reportingFile)
+	if _, err := os.Stat(filePath); os.IsNotExist(err) {
+		t.Fatalf("Expected file %s to exist, but it doesn't", filePath)
+	}
+
+	/* #nosec G304 */
+	content, err := os.ReadFile(filePath)
+	if err != nil {
+		t.Fatalf("Failed to read file: %v", err)
+	}
+
+	var readInfo licenseInfo
+	err = json.Unmarshal(content, &readInfo)
+	if err != nil {
+		t.Fatalf("Failed to unmarshal JSON: %v", err)
+	}
+
+	if readInfo != *info {
+		t.Errorf("Written info does not match original. Got %+v, want %+v", readInfo, *info)
+	}
+}
+
+func TestNewLicenseReporter(t *testing.T) {
+	cfg := LicenseReporterConfig{
+		Period:          time.Minute,
+		K8sClientReader: fake.NewSimpleClientset(),
+		PodNSName:       types.NamespacedName{Namespace: "default", Name: "test-pod"},
+	}
+
+	reporter := NewLicenseReporter(cfg)
+	if reporter == nil {
+		t.Fatal("NewLicenseReporter() returned nil")
+	}
+	if reporter.config != cfg {
+		t.Errorf("NewLicenseReporter() config = %v, want %v", reporter.config, cfg)
+	}
+}