Skip to content

Commit 50fbe71

Browse files
committed
add namespaces back
Signed-off-by: Haywood Shannon <[email protected]> Signed-off-by: Haywood Shannon <[email protected]>
1 parent e10b178 commit 50fbe71

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

internal/k8s/controller.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2242,7 +2242,7 @@ func (lbc *LoadBalancerController) createIngressEx(ing *networking.Ingress, vali
22422242
var external bool
22432243
svc, err := lbc.getServiceForIngressBackend(ing.Spec.DefaultBackend, ing.Namespace)
22442244
if err != nil {
2245-
nl.Warnf(lbc.Logger, "Error getting service %v: %v", ing.Spec.DefaultBackend.Service.Name, err)
2245+
nl.Warnf(lbc.Logger, "Error getting service %v/%v: %v", ing.Namespace, ing.Spec.DefaultBackend.Service.Name, err)
22462246
} else {
22472247
podEndps, external, err = lbc.getEndpointsForIngressBackend(ing.Spec.DefaultBackend, svc)
22482248
if err == nil && external && lbc.isNginxPlus {
@@ -2251,7 +2251,7 @@ func (lbc *LoadBalancerController) createIngressEx(ing *networking.Ingress, vali
22512251
}
22522252

22532253
if err != nil {
2254-
nl.Warnf(lbc.Logger, "Error retrieving endpoints for the service %v: %v", ing.Spec.DefaultBackend.Service.Name, err)
2254+
nl.Warnf(lbc.Logger, "Error retrieving endpoints for the service %v/%v: %v", ing.Namespace, ing.Spec.DefaultBackend.Service.Name, err)
22552255
}
22562256

22572257
if svc != nil && !external && hasUseClusterIP {
@@ -2310,7 +2310,7 @@ func (lbc *LoadBalancerController) createIngressEx(ing *networking.Ingress, vali
23102310
var external bool
23112311
svc, err := lbc.getServiceForIngressBackend(&path.Backend, ing.Namespace)
23122312
if err != nil {
2313-
nl.Debugf(lbc.Logger, "Error getting service %v: %v", &path.Backend.Service.Name, err)
2313+
nl.Debugf(lbc.Logger, "Error getting service %v/%v: %v", ing.Namespace, path.Backend.Service.Name, err)
23142314
} else {
23152315
podEndps, external, err = lbc.getEndpointsForIngressBackend(&path.Backend, svc)
23162316
if err == nil && external && lbc.isNginxPlus {
@@ -2319,7 +2319,7 @@ func (lbc *LoadBalancerController) createIngressEx(ing *networking.Ingress, vali
23192319
}
23202320

23212321
if err != nil {
2322-
nl.Warnf(lbc.Logger, "Error retrieving endpoints for the service %v: %v", path.Backend.Service.Name, err)
2322+
nl.Warnf(lbc.Logger, "Error retrieving endpoints for the service %v/%v: %v", ing.Namespace, path.Backend.Service.Name, err)
23232323
}
23242324

23252325
if svc != nil && !external && hasUseClusterIP {
@@ -2949,7 +2949,7 @@ func (lbc *LoadBalancerController) getTransportServerBackupEndpointsAndKey(trans
29492949
func (lbc *LoadBalancerController) getEndpointsForUpstream(namespace string, upstreamService string, upstreamPort uint16) (endps []podEndpoint, isExternal bool, err error) {
29502950
svc, err := lbc.getServiceForUpstream(namespace, upstreamService, upstreamPort)
29512951
if err != nil {
2952-
return nil, false, fmt.Errorf("error getting service %v: %w", upstreamService, err)
2952+
return nil, false, fmt.Errorf("error getting service %v/%v: %w", namespace, upstreamService, err)
29532953
}
29542954

29552955
backend := &networking.IngressBackend{
@@ -2963,7 +2963,7 @@ func (lbc *LoadBalancerController) getEndpointsForUpstream(namespace string, ups
29632963

29642964
endps, isExternal, err = lbc.getEndpointsForIngressBackend(backend, svc)
29652965
if err != nil {
2966-
return nil, false, fmt.Errorf("error retrieving endpoints for the service %v: %w", upstreamService, err)
2966+
return nil, false, fmt.Errorf("error retrieving endpoints for the service %v/%v: %w", namespace, upstreamService, err)
29672967
}
29682968

29692969
return endps, isExternal, err
@@ -2972,7 +2972,7 @@ func (lbc *LoadBalancerController) getEndpointsForUpstream(namespace string, ups
29722972
func (lbc *LoadBalancerController) getEndpointsForSubselector(namespace string, serviceName string, servicePort uint16, subselector map[string]string) (endps []podEndpoint, err error) {
29732973
svc, err := lbc.getServiceForUpstream(namespace, serviceName, servicePort)
29742974
if err != nil {
2975-
return nil, fmt.Errorf("error getting service %v: %w", serviceName, err)
2975+
return nil, fmt.Errorf("error getting service %v/%v: %w", namespace, serviceName, err)
29762976
}
29772977

29782978
var targetPort int32
@@ -2993,7 +2993,7 @@ func (lbc *LoadBalancerController) getEndpointsForSubselector(namespace string,
29932993

29942994
endps, err = lbc.getEndpointsForServiceWithSubselector(targetPort, subselector, svc)
29952995
if err != nil {
2996-
return nil, fmt.Errorf("error retrieving endpoints for the service %v: %w", serviceName, err)
2996+
return nil, fmt.Errorf("error retrieving endpoints for the service %v/%v: %w", namespace, serviceName, err)
29972997
}
29982998

29992999
return endps, err
@@ -3094,7 +3094,7 @@ func getPodName(pod *api_v1.ObjectReference) string {
30943094
func (lbc *LoadBalancerController) getHealthChecksForIngressBackend(backend *networking.IngressBackend, namespace string) *api_v1.Probe {
30953095
svc, err := lbc.getServiceForIngressBackend(backend, namespace)
30963096
if err != nil {
3097-
nl.Debugf(lbc.Logger, "Error getting service %v: %v", backend.Service.Name, err)
3097+
nl.Debugf(lbc.Logger, "Error getting service %v/%v: %v", namespace, backend.Service.Name, err)
30983098
return nil
30993099
}
31003100
svcPort := lbc.getServicePortForIngressPort(backend.Service.Port, svc)
@@ -3217,7 +3217,7 @@ func (lbc *LoadBalancerController) getEndpointsForPortFromEndpointSlices(endpoin
32173217

32183218
endpoints := makePodEndpoints(targetPort, filterReadyEndpointsFrom(selectEndpointSlicesForPort(targetPort, endpointSlices)))
32193219
if len(endpoints) == 0 {
3220-
return nil, fmt.Errorf("no endpointslices for target port %v in service %s", targetPort, svc.Name)
3220+
return nil, fmt.Errorf("no endpointslices for target port %v in service %s/%s", targetPort, svc.Namespace, svc.Name)
32213221
}
32223222
return endpoints, nil
32233223
}

0 commit comments

Comments
 (0)