Skip to content

Commit 5440ac4

Browse files
authored
Login to dockerhub when building authenticated images (#8293)
1 parent 2308408 commit 5440ac4

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

.github/workflows/build-oss.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,13 @@ jobs:
7878
password: ${{ steps.auth.outputs.access_token }}
7979
if: ${{ inputs.authenticated }}
8080

81+
- name: DockerHub Login
82+
uses: docker/login-action@184bdaa0721073962dff0199f1fb9940f07167d1 # v3.5.0
83+
with:
84+
username: ${{ secrets.DOCKER_USERNAME }}
85+
password: ${{ secrets.DOCKER_PASSWORD }}
86+
if: ${{ inputs.authenticated }}
87+
8188
- name: Docker meta
8289
id: meta
8390
uses: docker/metadata-action@c1e51972afc2121e065aed6d45c65596fe445f3f # v5.8.0
@@ -187,13 +194,6 @@ jobs:
187194
mkdir -p "${{ inputs.image }}-results/"
188195
if: ${{ inputs.authenticated && steps.build-push.conclusion == 'success' }}
189196

190-
- name: DockerHub Login for Docker Scout
191-
uses: docker/login-action@184bdaa0721073962dff0199f1fb9940f07167d1 # v3.5.0
192-
with:
193-
username: ${{ secrets.DOCKER_USERNAME }}
194-
password: ${{ secrets.DOCKER_PASSWORD }}
195-
if: ${{ inputs.authenticated && steps.build-push.conclusion == 'success' }}
196-
197197
- name: Run Docker Scout vulnerability scanner
198198
id: docker-scout
199199
uses: docker/scout-action@f8c776824083494ab0d56b8105ba2ca85c86e4de # v1.18.2

.github/workflows/build-plus.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,13 @@ jobs:
8080
password: ${{ steps.auth.outputs.access_token }}
8181
if: ${{ inputs.authenticated }}
8282

83+
- name: DockerHub Login
84+
uses: docker/login-action@184bdaa0721073962dff0199f1fb9940f07167d1 # v3.5.0
85+
with:
86+
username: ${{ secrets.DOCKER_USERNAME }}
87+
password: ${{ secrets.DOCKER_PASSWORD }}
88+
if: ${{ inputs.authenticated }}
89+
8390
- name: NAP modules
8491
id: nap_modules
8592
run: |
@@ -203,13 +210,6 @@ jobs:
203210
mkdir -p "${{ inputs.image }}-results/"
204211
if: ${{ inputs.authenticated && steps.build-push.conclusion == 'success' }}
205212

206-
- name: DockerHub Login for Docker Scout
207-
uses: docker/login-action@184bdaa0721073962dff0199f1fb9940f07167d1 # v3.5.0
208-
with:
209-
username: ${{ secrets.DOCKER_USERNAME }}
210-
password: ${{ secrets.DOCKER_PASSWORD }}
211-
if: ${{ inputs.authenticated && steps.build-push.conclusion == 'success' }}
212-
213213
- name: Run Docker Scout vulnerability scanner
214214
id: docker-scout
215215
uses: docker/scout-action@f8c776824083494ab0d56b8105ba2ca85c86e4de # v1.18.2

0 commit comments

Comments
 (0)