Skip to content

Commit 62642a5

Browse files
authored
refactor: replace glog in configs package (#6584)
1 parent 9cec24e commit 62642a5

30 files changed

+628
-573
lines changed

cmd/nginx-ingress/main.go

Lines changed: 19 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,8 @@ func main() {
130130

131131
mustProcessGlobalConfiguration(ctx)
132132

133-
cfgParams := configs.NewDefaultConfigParams(*nginxPlus)
134-
cfgParams = processConfigMaps(ctx, kubeClient, cfgParams, nginxManager, templateExecutor)
133+
cfgParams := configs.NewDefaultConfigParams(ctx, *nginxPlus)
134+
cfgParams = processConfigMaps(kubeClient, cfgParams, nginxManager, templateExecutor)
135135

136136
staticCfgParams := &configs.StaticConfigParams{
137137
DisableIPV6: *disableIPV6,
@@ -162,7 +162,7 @@ func main() {
162162
AppProtectBundlePath: appProtectBundlePath,
163163
}
164164

165-
mustProcessNginxConfig(ctx, staticCfgParams, cfgParams, templateExecutor, nginxManager)
165+
mustProcessNginxConfig(staticCfgParams, cfgParams, templateExecutor, nginxManager)
166166

167167
if *enableTLSPassthrough {
168168
var emptyFile []byte
@@ -202,7 +202,7 @@ func main() {
202202
)
203203

204204
if *enableServiceInsight {
205-
createHealthProbeEndpoint(ctx, kubeClient, plusClient, cnf)
205+
createHealthProbeEndpoint(kubeClient, plusClient, cnf)
206206
}
207207

208208
lbcInput := k8s.NewLoadBalancerControllerInput{
@@ -266,7 +266,7 @@ func main() {
266266
}()
267267
}
268268

269-
go handleTermination(ctx, lbc, nginxManager, syslogListener, process)
269+
go handleTermination(lbc, nginxManager, syslogListener, process)
270270

271271
lbc.Run()
272272

@@ -606,8 +606,8 @@ func createGlobalConfigurationValidator() *cr_validation.GlobalConfigurationVali
606606

607607
// mustProcessNginxConfig calls internally os.Exit
608608
// if can't generate a valid NGINX config.
609-
func mustProcessNginxConfig(ctx context.Context, staticCfgParams *configs.StaticConfigParams, cfgParams *configs.ConfigParams, templateExecutor *version1.TemplateExecutor, nginxManager nginx.Manager) {
610-
l := nl.LoggerFromContext(ctx)
609+
func mustProcessNginxConfig(staticCfgParams *configs.StaticConfigParams, cfgParams *configs.ConfigParams, templateExecutor *version1.TemplateExecutor, nginxManager nginx.Manager) {
610+
l := nl.LoggerFromContext(cfgParams.Context)
611611
ngxConfig := configs.GenerateNginxMainConfig(staticCfgParams, cfgParams)
612612
content, err := templateExecutor.ExecuteMainConfigTemplate(ngxConfig)
613613
if err != nil {
@@ -655,24 +655,23 @@ func getAndValidateSecret(kubeClient *kubernetes.Clientset, secretNsName string)
655655
return secret, nil
656656
}
657657

658-
func handleTermination(ctx context.Context, lbc *k8s.LoadBalancerController, nginxManager nginx.Manager, listener metrics.SyslogListener, cpcfg childProcesses) {
659-
l := nl.LoggerFromContext(ctx)
658+
func handleTermination(lbc *k8s.LoadBalancerController, nginxManager nginx.Manager, listener metrics.SyslogListener, cpcfg childProcesses) {
660659
signalChan := make(chan os.Signal, 1)
661660
signal.Notify(signalChan, syscall.SIGTERM)
662661

663662
select {
664663
case err := <-cpcfg.nginxDone:
665664
if err != nil {
666-
nl.Fatalf(l, "nginx command exited unexpectedly with status: %v", err)
665+
nl.Fatalf(lbc.Logger, "nginx command exited unexpectedly with status: %v", err)
667666
} else {
668-
nl.Info(l, "nginx command exited successfully")
667+
nl.Info(lbc.Logger, "nginx command exited successfully")
669668
}
670669
case err := <-cpcfg.aPPluginDone:
671-
nl.Fatalf(l, "AppProtectPlugin command exited unexpectedly with status: %v", err)
670+
nl.Fatalf(lbc.Logger, "AppProtectPlugin command exited unexpectedly with status: %v", err)
672671
case err := <-cpcfg.aPDosDone:
673-
nl.Fatalf(l, "AppProtectDosAgent command exited unexpectedly with status: %v", err)
672+
nl.Fatalf(lbc.Logger, "AppProtectDosAgent command exited unexpectedly with status: %v", err)
674673
case <-signalChan:
675-
nl.Info(l, "Received SIGTERM, shutting down")
674+
nl.Info(lbc.Logger, "Received SIGTERM, shutting down")
676675
lbc.Stop()
677676
nginxManager.Quit()
678677
<-cpcfg.nginxDone
@@ -686,7 +685,7 @@ func handleTermination(ctx context.Context, lbc *k8s.LoadBalancerController, ngi
686685
}
687686
listener.Stop()
688687
}
689-
nl.Info(l, "Exiting successfully")
688+
nl.Info(lbc.Logger, "Exiting successfully")
690689
os.Exit(0)
691690
}
692691

@@ -801,8 +800,8 @@ func createPlusAndLatencyCollectors(
801800
return plusCollector, syslogListener, lc
802801
}
803802

804-
func createHealthProbeEndpoint(ctx context.Context, kubeClient *kubernetes.Clientset, plusClient *client.NginxClient, cnf *configs.Configurator) {
805-
l := nl.LoggerFromContext(ctx)
803+
func createHealthProbeEndpoint(kubeClient *kubernetes.Clientset, plusClient *client.NginxClient, cnf *configs.Configurator) {
804+
l := nl.LoggerFromContext(cnf.CfgParams.Context)
806805
if !*enableServiceInsight {
807806
return
808807
}
@@ -834,8 +833,8 @@ func mustProcessGlobalConfiguration(ctx context.Context) {
834833
}
835834
}
836835

837-
func processConfigMaps(ctx context.Context, kubeClient *kubernetes.Clientset, cfgParams *configs.ConfigParams, nginxManager nginx.Manager, templateExecutor *version1.TemplateExecutor) *configs.ConfigParams {
838-
l := nl.LoggerFromContext(ctx)
836+
func processConfigMaps(kubeClient *kubernetes.Clientset, cfgParams *configs.ConfigParams, nginxManager nginx.Manager, templateExecutor *version1.TemplateExecutor) *configs.ConfigParams {
837+
l := nl.LoggerFromContext(cfgParams.Context)
839838
if *nginxConfigMaps != "" {
840839
ns, name, err := k8s.ParseNamespaceName(*nginxConfigMaps)
841840
if err != nil {
@@ -845,7 +844,7 @@ func processConfigMaps(ctx context.Context, kubeClient *kubernetes.Clientset, cf
845844
if err != nil {
846845
nl.Fatalf(l, "Error when getting %v: %v", *nginxConfigMaps, err)
847846
}
848-
cfgParams = configs.ParseConfigMap(cfm, *nginxPlus, *appProtect, *appProtectDos, *enableTLSPassthrough)
847+
cfgParams = configs.ParseConfigMap(cfgParams.Context, cfm, *nginxPlus, *appProtect, *appProtectDos, *enableTLSPassthrough)
849848
if cfgParams.MainServerSSLDHParamFileContent != nil {
850849
fileName, err := nginxManager.CreateDHParam(*cfgParams.MainServerSSLDHParamFileContent)
851850
if err != nil {

0 commit comments

Comments
 (0)