Skip to content

Commit 705a353

Browse files
pleshakovciarams87
authored andcommitted
Update python tests
1 parent cfdbad2 commit 705a353

File tree

5 files changed

+23
-10
lines changed

5 files changed

+23
-10
lines changed

tests/suite/test_annotations.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ def fin():
165165
@pytest.mark.ingresses
166166
@pytest.mark.parametrize('annotations_setup', ["standard", "mergeable"], indirect=True)
167167
class TestAnnotations:
168-
def test_nginx_config_defaults(self, kube_apis, annotations_setup, ingress_controller_prerequisites):
168+
def test_nginx_config_defaults(self, kube_apis, annotations_setup, ingress_controller_prerequisites, cli_arguments):
169169
print("Case 1: no ConfigMap keys, no annotations in Ingress")
170170
result_conf = get_ingress_nginx_template_conf(kube_apis.v1,
171171
annotations_setup.namespace,
@@ -178,8 +178,12 @@ def test_nginx_config_defaults(self, kube_apis, annotations_setup, ingress_contr
178178

179179
assert "Strict-Transport-Security" not in result_conf
180180

181+
expected_zone_size = "256k"
182+
if cli_arguments["ic-type"] == "nginx-plus-ingress":
183+
expected_zone_size = "512k"
184+
181185
for upstream in annotations_setup.upstream_names:
182-
assert f"zone {upstream} 256k;" in result_conf
186+
assert f"zone {upstream} {expected_zone_size};" in result_conf
183187

184188
@pytest.mark.parametrize('annotations, expected_strings, unexpected_strings', [
185189
({"nginx.org/proxy-send-timeout": "10s", "nginx.org/max-conns": "1024",
@@ -318,7 +322,7 @@ def test_upstream_zone_size_0(self, cli_arguments, kube_apis,
318322
if cli_arguments["ic-type"] == "nginx-plus-ingress":
319323
print("Run assertions for Nginx Plus case")
320324
assert "zone " in result_conf
321-
assert " 256k;" in result_conf
325+
assert " 512k;" in result_conf
322326
elif cli_arguments["ic-type"] == "nginx-ingress":
323327
print("Run assertions for Nginx OSS case")
324328
assert "zone " not in result_conf

tests/suite/test_externalname_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def test_ic_template_config_upstream_zone(self, kube_apis, ingress_controller_pr
9393
ingress_controller_prerequisites.namespace)
9494
line = f"zone {external_name_setup.namespace}-" \
9595
f"{external_name_setup.ingress_name}-" \
96-
f"{external_name_setup.ingress_host}-{external_name_setup.service}-80 256k;"
96+
f"{external_name_setup.ingress_host}-{external_name_setup.service}-80 512k;"
9797
assert line in result_conf
9898

9999
def test_ic_template_config_upstream_rule(self, kube_apis, ingress_controller_prerequisites,

tests/suite/test_v_s_route_externalname.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ def test_template_config(self, kube_apis,
123123
ingress_controller_prerequisites.namespace)
124124

125125
line = f"zone vs_{vsr_externalname_setup.namespace}_{vsr_externalname_setup.vs_name}" \
126-
f"_vsr_{vsr_externalname_setup.route.namespace}_{vsr_externalname_setup.route.name}_ext-backend 256k;"
126+
f"_vsr_{vsr_externalname_setup.route.namespace}_{vsr_externalname_setup.route.name}_ext-backend 512k;"
127127
assert line in initial_config
128128
assert "random two least_conn;" in initial_config
129129
assert f"server {vsr_externalname_setup.external_host}:80 max_fails=1 fail_timeout=10s max_conns=0 resolve;"\

tests/suite/test_virtual_server_configmap_keys.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def assert_specific_keys_for_nginx_plus(config, expected_values):
6969
assert f"server_tokens \"{expected_values['server-tokens']}\";" in config
7070
assert "random two least_conn;" not in config \
7171
and expected_values['lb-method'] in config
72-
assert "zone " in config and " 256k;" in config
72+
assert "zone " in config and " 512k;" in config
7373

7474

7575
def assert_specific_keys_for_nginx_oss(config, expected_values):
@@ -79,8 +79,15 @@ def assert_specific_keys_for_nginx_oss(config, expected_values):
7979
and expected_values['lb-method'] in config
8080
assert "zone " not in config and " 256k;" not in config
8181

82+
def assert_defaults_of_keys_with_validation_for_nginx_plus(config, unexpected_values):
83+
assert_common_defaults_of_keys_with_validation(config, unexpected_values)
84+
assert "zone " in config and " 512k;" in config
85+
86+
def assert_defaults_of_keys_with_validation_for_nginx_oss(config, unexpected_values):
87+
assert_common_defaults_of_keys_with_validation(config, unexpected_values)
88+
assert "zone " in config and " 256k;" in config
8289

83-
def assert_defaults_of_keys_with_validation(config, unexpected_values):
90+
def assert_common_defaults_of_keys_with_validation(config, unexpected_values):
8491
assert "proxy_buffering on;" in config
8592
assert "real_ip_recursive" not in config
8693
assert "max_fails=1" in config
@@ -89,7 +96,6 @@ def assert_defaults_of_keys_with_validation(config, unexpected_values):
8996
assert "server_tokens \"on\"" in config
9097
assert "random two least_conn;" in config and unexpected_values['lb-method'] not in config
9198
assert f"proxy_send_timeout 60s;" in config
92-
assert "zone " in config and " 256k;" in config
9399

94100

95101
def assert_defaults_of_keys_with_validation_in_main_config(config, unexpected_values):
@@ -222,7 +228,10 @@ def test_keys(self, cli_arguments, kube_apis, ingress_controller_prerequisites,
222228
ingress_controller_prerequisites.namespace)
223229
step_4_events = get_events(kube_apis.v1, virtual_server_setup.namespace)
224230
assert_update_event_count_increased(virtual_server_setup, step_4_events, step_3_events)
225-
assert_defaults_of_keys_with_validation(step_4_config, expected_values)
231+
if cli_arguments['ic-type'] == "nginx-ingress":
232+
assert_defaults_of_keys_with_validation_for_nginx_oss(step_4_config, expected_values)
233+
else:
234+
assert_defaults_of_keys_with_validation_for_nginx_plus(step_4_config, expected_values)
226235

227236
def test_keys_in_main_config(self, cli_arguments, kube_apis, ingress_controller_prerequisites,
228237
crd_ingress_controller, virtual_server_setup, clean_up):

tests/suite/test_virtual_server_external_name.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def test_template_config(self, kube_apis, ingress_controller_prerequisites,
7878
virtual_server_setup.vs_name,
7979
vs_externalname_setup.ic_pod_name,
8080
ingress_controller_prerequisites.namespace)
81-
line = f"zone vs_{virtual_server_setup.namespace}_{virtual_server_setup.vs_name}_backend1 256k;"
81+
line = f"zone vs_{virtual_server_setup.namespace}_{virtual_server_setup.vs_name}_backend1 512k;"
8282
assert line in result_conf
8383
assert "random two least_conn;" in result_conf
8484
assert f"server {vs_externalname_setup.external_host}:80 max_fails=1 fail_timeout=10s max_conns=0 resolve;"\

0 commit comments

Comments
 (0)