Skip to content

Commit 8e22e63

Browse files
authored
Merge branch 'main' into deps/image-update-main-0d5e5bc8
2 parents 11f3824 + 214d9f1 commit 8e22e63

File tree

11 files changed

+2038
-87
lines changed

11 files changed

+2038
-87
lines changed

.pre-commit-config.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ repos:
4444
pass_filenames: false
4545

4646
- repo: https://github.com/golangci/golangci-lint
47-
rev: v1.61.0
47+
rev: v1.62.0
4848
hooks:
4949
- id: golangci-lint
5050
args: [--new-from-patch=/tmp/diff.patch]
@@ -86,7 +86,7 @@ repos:
8686
args: ["--schemafile", "charts/nginx-ingress/values.schema.json"]
8787

8888
- repo: https://github.com/DavidAnson/markdownlint-cli2
89-
rev: v0.14.0
89+
rev: v0.15.0
9090
hooks:
9191
- id: markdownlint-cli2
9292

charts/nginx-ingress/values.schema.json

Lines changed: 52 additions & 52 deletions
Large diffs are not rendered by default.

internal/configs/configmaps.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -359,10 +359,14 @@ func ParseConfigMap(ctx context.Context, cfgm *v1.ConfigMap, nginxPlus bool, has
359359

360360
if virtualServerTemplate, exists := cfgm.Data["virtualserver-template"]; exists {
361361
cfgParams.VirtualServerTemplate = &virtualServerTemplate
362+
} else {
363+
cfgParams.VirtualServerTemplate = nil
362364
}
363365

364366
if transportServerTemplate, exists := cfgm.Data["transportserver-template"]; exists {
365367
cfgParams.TransportServerTemplate = &transportServerTemplate
368+
} else {
369+
cfgParams.TransportServerTemplate = nil
366370
}
367371

368372
if mainStreamSnippets, exists := GetMapKeyAsStringSlice(cfgm.Data, "stream-snippets", cfgm, "\n"); exists {

internal/configs/configurator.go

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1318,7 +1318,7 @@ func (cnf *Configurator) UpdateConfig(cfgParams *ConfigParams, resources Extende
13181318
return allWarnings, fmt.Errorf("error when parsing the main template: %w", err)
13191319
}
13201320
} else {
1321-
// Reverse to default main template parsed at NIC startup.
1321+
// Reverse to default Main template parsed at NIC startup.
13221322
cnf.templateExecutor.UseOriginalMainTemplate()
13231323
}
13241324

@@ -1327,20 +1327,29 @@ func (cnf *Configurator) UpdateConfig(cfgParams *ConfigParams, resources Extende
13271327
if err != nil {
13281328
return allWarnings, fmt.Errorf("error when parsing the ingress template: %w", err)
13291329
}
1330+
} else {
1331+
// Reverse to default Ingress template parsed at NIC startup.
1332+
cnf.templateExecutor.UseOriginalIngressTemplate()
13301333
}
13311334

13321335
if cfgParams.VirtualServerTemplate != nil {
13331336
err := cnf.templateExecutorV2.UpdateVirtualServerTemplate(cfgParams.VirtualServerTemplate)
13341337
if err != nil {
13351338
return allWarnings, fmt.Errorf("error when parsing the VirtualServer template: %w", err)
13361339
}
1340+
} else {
1341+
// Reverse to default TransportServer template parsed at NIC startup.
1342+
cnf.templateExecutorV2.UseOriginalVStemplate()
13371343
}
13381344

13391345
if cfgParams.TransportServerTemplate != nil {
13401346
err := cnf.templateExecutorV2.UpdateTransportServerTemplate(cfgParams.TransportServerTemplate)
13411347
if err != nil {
13421348
return allWarnings, fmt.Errorf("error when parsing the TransportServer template: %w", err)
13431349
}
1350+
} else {
1351+
// Reverse to default TransportServer template parsed at NIC startup.
1352+
cnf.templateExecutorV2.UseOriginalTStemplate()
13441353
}
13451354

13461355
mainCfg := GenerateNginxMainConfig(cnf.staticCfgParams, cfgParams)

0 commit comments

Comments
 (0)