Skip to content

Commit 9faee4b

Browse files
chase-kieferlucacome
authored andcommitted
Add missing OSS internal routes (#3481)
During testing a bug was found that prevented NSM to egress through NIC OSS. The root cause of the bug was found to be a few missing configuration blocks in the OSS NIC template files. This adds in the server blocks necessary for internal routes to function as expected. (cherry picked from commit 21f5377)
1 parent 119fc48 commit 9faee4b

File tree

3 files changed

+46
-0
lines changed

3 files changed

+46
-0
lines changed

internal/configs/version1/nginx.ingress.tmpl

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,12 @@ upstream {{$upstream.Name}} {
1010

1111
{{range $server := .Servers}}
1212
server {
13+
{{if $server.SpiffeCerts}}
14+
listen 443 ssl;
15+
{{if not $server.DisableIPV6}}listen [::]:443 ssl;{{end}}
16+
ssl_certificate /etc/nginx/secrets/spiffe_cert.pem;
17+
ssl_certificate_key /etc/nginx/secrets/spiffe_key.pem;
18+
{{else}}
1319
{{if not $server.GRPCOnly}}
1420
{{range $port := $server.Ports}}
1521
listen {{$port}}{{if $server.ProxyProtocol}} proxy_protocol{{end}};
@@ -35,6 +41,7 @@ server {
3541
ssl_certificate_key {{$server.SSLCertificateKey}};
3642
{{end}}
3743
{{end}}
44+
{{end}}
3845

3946
{{range $setRealIPFrom := $server.SetRealIPFrom}}
4047
set_real_ip_from {{$setRealIPFrom}};{{end}}
@@ -142,6 +149,15 @@ server {
142149
{{- if $location.ProxyBufferSize}}
143150
grpc_buffer_size {{$location.ProxyBufferSize}};
144151
{{- end}}
152+
{{if $.SpiffeClientCerts}}
153+
grpc_ssl_certificate /etc/nginx/secrets/spiffe_cert.pem;
154+
grpc_ssl_certificate_key /etc/nginx/secrets/spiffe_key.pem;
155+
grpc_ssl_trusted_certificate /etc/nginx/secrets/spiffe_rootca.pem;
156+
grpc_ssl_server_name on;
157+
grpc_ssl_verify on;
158+
grpc_ssl_verify_depth 25;
159+
grpc_ssl_name {{$location.ProxySSLName}};
160+
{{end}}
145161
{{if $location.SSL}}
146162
grpc_pass grpcs://{{$location.Upstream.Name}}{{$location.Rewrite}};
147163
{{else}}
@@ -187,6 +203,15 @@ server {
187203
{{- if $location.ProxyMaxTempFileSize}}
188204
proxy_max_temp_file_size {{$location.ProxyMaxTempFileSize}};
189205
{{- end}}
206+
{{if $.SpiffeClientCerts}}
207+
proxy_ssl_certificate /etc/nginx/secrets/spiffe_cert.pem;
208+
proxy_ssl_certificate_key /etc/nginx/secrets/spiffe_key.pem;
209+
proxy_ssl_trusted_certificate /etc/nginx/secrets/spiffe_rootca.pem;
210+
proxy_ssl_server_name on;
211+
proxy_ssl_verify on;
212+
proxy_ssl_verify_depth 25;
213+
proxy_ssl_name {{$location.ProxySSLName}};
214+
{{end}}
190215
{{if $location.SSL}}
191216
proxy_pass https://{{$location.Upstream.Name}}{{$location.Rewrite}};
192217
{{else}}

internal/configs/version1/nginx.tmpl

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -210,6 +210,18 @@ http {
210210

211211
return 418;
212212
}
213+
{{if .InternalRouteServer}}
214+
server {
215+
listen 443 ssl;
216+
{{if not .DisableIPV6}}listen [::]:443 ssl;{{end}}
217+
server_name {{.InternalRouteServerName}};
218+
ssl_certificate /etc/nginx/secrets/spiffe_cert.pem;
219+
ssl_certificate_key /etc/nginx/secrets/spiffe_key.pem;
220+
ssl_client_certificate /etc/nginx/secrets/spiffe_rootca.pem;
221+
ssl_verify_client on;
222+
ssl_verify_depth 25;
223+
}
224+
{{end}}
213225
}
214226

215227
stream {

internal/configs/version2/nginx.virtualserver.tmpl

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -356,6 +356,15 @@ server {
356356
{{ end }}
357357
{{ range $h := $l.AddHeaders }}
358358
add_header {{ $h.Name }} "{{ $h.Value }}" {{ if $h.Always }}always{{ end }};
359+
{{ end }}
360+
{{ if $.SpiffeCerts }}
361+
{{ $proxyOrGRPC }}_ssl_certificate /etc/nginx/secrets/spiffe_cert.pem;
362+
{{ $proxyOrGRPC }}_ssl_certificate_key /etc/nginx/secrets/spiffe_key.pem;
363+
{{ $proxyOrGRPC }}_ssl_trusted_certificate /etc/nginx/secrets/spiffe_rootca.pem;
364+
{{ $proxyOrGRPC }}_ssl_server_name on;
365+
{{ $proxyOrGRPC }}_ssl_verify on;
366+
{{ $proxyOrGRPC }}_ssl_verify_depth 25;
367+
{{ $proxyOrGRPC }}_ssl_name {{ $l.ProxySSLName }};
359368
{{ end }}
360369
{{if $l.GRPCPass}}
361370
grpc_pass {{ $l.GRPCPass }};

0 commit comments

Comments
 (0)