Skip to content

Commit b587d04

Browse files
authored
Merge branch 'main' into deps/image-update-main-a6e855ad
2 parents 08d599d + 6007227 commit b587d04

File tree

5 files changed

+11
-13
lines changed

5 files changed

+11
-13
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ go 1.23.3
55
require (
66
github.com/aws/aws-sdk-go-v2/config v1.28.5
77
github.com/aws/aws-sdk-go-v2/service/marketplacemetering v1.25.6
8-
github.com/cert-manager/cert-manager v1.16.1
8+
github.com/cert-manager/cert-manager v1.16.2
99
github.com/dlclark/regexp2 v1.11.4
1010
github.com/gkampitakis/go-snaps v0.5.7
1111
github.com/go-kit/log v0.2.1

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ github.com/blang/semver/v4 v4.0.0 h1:1PFHFE6yCCTv8C1TeyNNarDzntLi7wMI5i/pzqYIsAM
3838
github.com/blang/semver/v4 v4.0.0/go.mod h1:IbckMUScFkM3pff0VJDNKRiT6TG/YpiHIM2yvyW5YoQ=
3939
github.com/cenkalti/backoff/v4 v4.3.0 h1:MyRJ/UdXutAwSAT+s3wNd7MfTIcy71VQueUuFK343L8=
4040
github.com/cenkalti/backoff/v4 v4.3.0/go.mod h1:Y3VNntkOUPxTVeUxJ/G5vcM//AlwfmyYozVcomhLiZE=
41-
github.com/cert-manager/cert-manager v1.16.1 h1:1ceFMqTtwiqY2vyfaRT85CNiVmK7pJjt3GebYCx9awY=
42-
github.com/cert-manager/cert-manager v1.16.1/go.mod h1:MfLVTL45hFZsqmaT1O0+b2ugaNNQQZttSFV9hASHUb0=
41+
github.com/cert-manager/cert-manager v1.16.2 h1:c9UU2E+8XWGruyvC/mdpc1wuLddtgmNr8foKdP7a8Jg=
42+
github.com/cert-manager/cert-manager v1.16.2/go.mod h1:MfLVTL45hFZsqmaT1O0+b2ugaNNQQZttSFV9hASHUb0=
4343
github.com/cespare/xxhash/v2 v2.3.0 h1:UL815xU9SqsFlibzuggzjXhog7bL6oX9BbNZnL2UFvs=
4444
github.com/cespare/xxhash/v2 v2.3.0/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs=
4545
github.com/coreos/go-semver v0.3.1 h1:yi21YpKnrx1gt5R+la8n5WgS0kCrsPp33dmEyHReZr4=

internal/configs/oidc/oidc.conf

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@
3939
internal;
4040
proxy_ssl_server_name on; # For SNI to the IdP
4141
proxy_set_header Content-Type "application/x-www-form-urlencoded";
42-
proxy_set_body "grant_type=authorization_code&client_id=$oidc_client&$args&redirect_uri=$redirect_base$redir_location";
43-
proxy_method POST;
42+
proxy_set_header Authorization $arg_secret_basic;
4443
proxy_pass $oidc_token_endpoint;
4544
}
4645

@@ -51,8 +50,7 @@
5150
internal;
5251
proxy_ssl_server_name on; # For SNI to the IdP
5352
proxy_set_header Content-Type "application/x-www-form-urlencoded";
54-
proxy_set_body "grant_type=refresh_token&refresh_token=$arg_token&client_id=$oidc_client&client_secret=$oidc_client_secret";
55-
proxy_method POST;
53+
proxy_set_header Authorization $arg_secret_basic;
5654
proxy_pass $oidc_token_endpoint;
5755
}
5856

internal/configs/version2/nginx-plus.virtualserver.tmpl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ server {
9090
include oidc/oidc.conf;
9191

9292
set $oidc_pkce_enable 0;
93+
set $oidc_client_auth_method "client_secret_post";
9394
set $oidc_logout_redirect "{{ $oidc.PostLogoutRedirectURI }}";
9495
set $oidc_hmac_key "{{ $s.VSName }}";
9596
set $zone_sync_leeway {{ $oidc.ZoneSyncLeeway }};

internal/k8s/controller.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1778,15 +1778,14 @@ func (lbc *LoadBalancerController) validationTLSSpecialSecret(secret *api_v1.Sec
17781778
func (lbc *LoadBalancerController) handleSpecialSecretUpdate(secret *api_v1.Secret) {
17791779
var specialTLSSecretsToUpdate []string
17801780
secretNsName := secret.Namespace + "/" + secret.Name
1781-
switch secretNsName {
1782-
case lbc.specialSecrets.defaultServerSecret:
1781+
1782+
if secretNsName == lbc.specialSecrets.defaultServerSecret {
17831783
lbc.validationTLSSpecialSecret(secret, configs.DefaultServerSecretFileName, &specialTLSSecretsToUpdate)
1784-
case lbc.specialSecrets.wildcardTLSSecret:
1784+
}
1785+
if secretNsName == lbc.specialSecrets.wildcardTLSSecret {
17851786
lbc.validationTLSSpecialSecret(secret, configs.WildcardSecretFileName, &specialTLSSecretsToUpdate)
1786-
default:
1787-
nl.Warnf(lbc.Logger, "special secret not found")
1788-
return
17891787
}
1788+
17901789
err := lbc.configurator.AddOrUpdateSpecialTLSSecrets(secret, specialTLSSecretsToUpdate)
17911790
if err != nil {
17921791
nl.Errorf(lbc.Logger, "Error when updating the special Secret %v: %v", secretNsName, err)

0 commit comments

Comments
 (0)