Skip to content

Commit ee2b551

Browse files
committed
add namespaces back
Signed-off-by: Haywood Shannon <[email protected]> Signed-off-by: Haywood Shannon <[email protected]>
1 parent c0d20a9 commit ee2b551

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

internal/k8s/controller.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2242,7 +2242,7 @@ func (lbc *LoadBalancerController) createIngressEx(ing *networking.Ingress, vali
22422242
var external bool
22432243
svc, err := lbc.getServiceForIngressBackend(ing.Spec.DefaultBackend, ing.Namespace)
22442244
if err != nil {
2245-
nl.Warnf(lbc.Logger, "Error getting service %v: %v", ing.Spec.DefaultBackend.Service.Name, err)
2245+
nl.Warnf(lbc.Logger, "Error getting service %v/%v: %v", ing.Namespace, ing.Spec.DefaultBackend.Service.Name, err)
22462246
} else {
22472247
podEndps, external, err = lbc.getEndpointsForIngressBackend(ing.Spec.DefaultBackend, svc)
22482248
if err == nil && external && lbc.isNginxPlus {
@@ -2251,7 +2251,7 @@ func (lbc *LoadBalancerController) createIngressEx(ing *networking.Ingress, vali
22512251
}
22522252

22532253
if err != nil {
2254-
nl.Warnf(lbc.Logger, "Error retrieving endpoints for the service %v: %v", ing.Spec.DefaultBackend.Service.Name, err)
2254+
nl.Warnf(lbc.Logger, "Error retrieving endpoints for the service %v/%v: %v", ing.Namespace, ing.Spec.DefaultBackend.Service.Name, err)
22552255
}
22562256

22572257
if svc != nil && !external && hasUseClusterIP {
@@ -2310,7 +2310,7 @@ func (lbc *LoadBalancerController) createIngressEx(ing *networking.Ingress, vali
23102310
var external bool
23112311
svc, err := lbc.getServiceForIngressBackend(&path.Backend, ing.Namespace)
23122312
if err != nil {
2313-
nl.Debugf(lbc.Logger, "Error getting service %v: %v", &path.Backend.Service.Name, err)
2313+
nl.Debugf(lbc.Logger, "Error getting service %v/%v: %v", ing.Namespace, path.Backend.Service.Name, err)
23142314
} else {
23152315
podEndps, external, err = lbc.getEndpointsForIngressBackend(&path.Backend, svc)
23162316
if err == nil && external && lbc.isNginxPlus {
@@ -2319,7 +2319,7 @@ func (lbc *LoadBalancerController) createIngressEx(ing *networking.Ingress, vali
23192319
}
23202320

23212321
if err != nil {
2322-
nl.Warnf(lbc.Logger, "Error retrieving endpoints for the service %v: %v", path.Backend.Service.Name, err)
2322+
nl.Warnf(lbc.Logger, "Error retrieving endpoints for the service %v/%v: %v", ing.Namespace, path.Backend.Service.Name, err)
23232323
}
23242324

23252325
if svc != nil && !external && hasUseClusterIP {
@@ -2981,7 +2981,7 @@ func (lbc *LoadBalancerController) getTransportServerBackupEndpointsAndKey(trans
29812981
func (lbc *LoadBalancerController) getEndpointsForUpstream(namespace string, upstreamService string, upstreamPort uint16) (endps []podEndpoint, isExternal bool, err error) {
29822982
svc, err := lbc.getServiceForUpstream(namespace, upstreamService, upstreamPort)
29832983
if err != nil {
2984-
return nil, false, fmt.Errorf("error getting service %v: %w", upstreamService, err)
2984+
return nil, false, fmt.Errorf("error getting service %v/%v: %w", namespace, upstreamService, err)
29852985
}
29862986

29872987
backend := &networking.IngressBackend{
@@ -2995,7 +2995,7 @@ func (lbc *LoadBalancerController) getEndpointsForUpstream(namespace string, ups
29952995

29962996
endps, isExternal, err = lbc.getEndpointsForIngressBackend(backend, svc)
29972997
if err != nil {
2998-
return nil, false, fmt.Errorf("error retrieving endpoints for the service %v: %w", upstreamService, err)
2998+
return nil, false, fmt.Errorf("error retrieving endpoints for the service %v/%v: %w", namespace, upstreamService, err)
29992999
}
30003000

30013001
return endps, isExternal, err
@@ -3004,7 +3004,7 @@ func (lbc *LoadBalancerController) getEndpointsForUpstream(namespace string, ups
30043004
func (lbc *LoadBalancerController) getEndpointsForSubselector(namespace string, serviceName string, servicePort uint16, subselector map[string]string) (endps []podEndpoint, err error) {
30053005
svc, err := lbc.getServiceForUpstream(namespace, serviceName, servicePort)
30063006
if err != nil {
3007-
return nil, fmt.Errorf("error getting service %v: %w", serviceName, err)
3007+
return nil, fmt.Errorf("error getting service %v/%v: %w", namespace, serviceName, err)
30083008
}
30093009

30103010
var targetPort int32
@@ -3025,7 +3025,7 @@ func (lbc *LoadBalancerController) getEndpointsForSubselector(namespace string,
30253025

30263026
endps, err = lbc.getEndpointsForServiceWithSubselector(targetPort, subselector, svc)
30273027
if err != nil {
3028-
return nil, fmt.Errorf("error retrieving endpoints for the service %v: %w", serviceName, err)
3028+
return nil, fmt.Errorf("error retrieving endpoints for the service %v/%v: %w", namespace, serviceName, err)
30293029
}
30303030

30313031
return endps, err
@@ -3126,7 +3126,7 @@ func getPodName(pod *api_v1.ObjectReference) string {
31263126
func (lbc *LoadBalancerController) getHealthChecksForIngressBackend(backend *networking.IngressBackend, namespace string) *api_v1.Probe {
31273127
svc, err := lbc.getServiceForIngressBackend(backend, namespace)
31283128
if err != nil {
3129-
nl.Debugf(lbc.Logger, "Error getting service %v: %v", backend.Service.Name, err)
3129+
nl.Debugf(lbc.Logger, "Error getting service %v/%v: %v", namespace, backend.Service.Name, err)
31303130
return nil
31313131
}
31323132
svcPort := lbc.getServicePortForIngressPort(backend.Service.Port, svc)
@@ -3249,7 +3249,7 @@ func (lbc *LoadBalancerController) getEndpointsForPortFromEndpointSlices(endpoin
32493249

32503250
endpoints := makePodEndpoints(targetPort, filterReadyEndpointsFrom(selectEndpointSlicesForPort(targetPort, endpointSlices)))
32513251
if len(endpoints) == 0 {
3252-
return nil, fmt.Errorf("no endpointslices for target port %v in service %s", targetPort, svc.Name)
3252+
return nil, fmt.Errorf("no endpointslices for target port %v in service %s/%s", targetPort, svc.Namespace, svc.Name)
32533253
}
32543254
return endpoints, nil
32553255
}

0 commit comments

Comments
 (0)