Skip to content

Commit fa5963d

Browse files
addressing comments
1 parent 6c32c16 commit fa5963d

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

pkg/apis/configuration/v1/types.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ type PolicyReference struct {
118118
type Upstream struct {
119119
// The name of the upstream. Must be a valid DNS label as defined in RFC 1035. For example, hello and upstream-123 are valid. The name must be unique among all upstreams of the resource.
120120
Name string `json:"name"`
121-
// The name of a service. The service must belong to the same namespace as the resource. If the service doesn’t exist, NGINX will assume the service has zero endpoints and return a 502 response for requests for this upstream. For NGINX Plus only, services of type ExternalName are also supported (check the prerequisites).
121+
// The name of a service. The service must belong to the same namespace as the resource. If the service doesn’t exist, NGINX will assume the service has zero endpoints and return a 502 response for requests for this upstream. For NGINX Plus only, services of type ExternalName are also supported .
122122
Service string `json:"service"`
123123
// Selects the pods within the service using label keys and values. By default, all pods of the service are selected. Note: the specified labels are expected to be present in the pods when they are created. If the pod labels are updated, NGINX Ingress Controller will not see that change until the number of the pods is changed.
124124
Subselector map[string]string `json:"subselector"`
@@ -548,7 +548,7 @@ type GlobalConfiguration struct {
548548
Spec GlobalConfigurationSpec `json:"spec"`
549549
}
550550

551-
// GlobalConfigurationSpec is the spec of the GlobalConfiguration resource.
551+
// The GlobalConfiguration resource defines the global configuration parameters of the Ingress Controller.
552552
type GlobalConfigurationSpec struct {
553553
// Listeners field of the GlobalConfigurationSpec resource
554554
Listeners []Listener `json:"listeners"`
@@ -596,7 +596,7 @@ type TransportServer struct {
596596
metav1.TypeMeta `json:",inline"`
597597
metav1.ObjectMeta `json:"metadata,omitempty"`
598598
Spec TransportServerSpec `json:"spec"`
599-
// status field of the TransportServer resource
599+
// The status of the TransportServer resource
600600
Status TransportServerStatus `json:"status"`
601601
}
602602

@@ -616,7 +616,7 @@ type TransportServerSpec struct {
616616
Host string `json:"host"`
617617
// A list of upstreams.
618618
Upstreams []TransportServerUpstream `json:"upstreams"`
619-
// The UpstreamParameters are set on stream context
619+
// UpstreamParameters defines parameters for an upstream.
620620
UpstreamParameters *UpstreamParameters `json:"upstreamParameters"`
621621
// The parameters of the session to be used for the Server context
622622
SessionParameters *SessionParameters `json:"sessionParameters"`
@@ -719,7 +719,7 @@ type TransportServerAction struct {
719719

720720
// TransportServerStatus defines the status for the TransportServer resource.
721721
type TransportServerStatus struct {
722-
// Represents the current state of the resource. There are three possible values: Valid, Invalid and Warning. Valid indicates that the resource has been validated and accepted by the Ingress Controller. Invalid means the resource failed validation or
722+
// Represents the current state of the resource. Possible values: Valid (resource validated and accepted), Invalid (validation failed or config reload failed), or Warning (validated but may work in degraded state).
723723
State string `json:"state"`
724724
// The reason of the current state of the resource.
725725
Reason string `json:"reason"`
@@ -750,7 +750,7 @@ type Policy struct {
750750
metav1.TypeMeta `json:",inline"`
751751
metav1.ObjectMeta `json:"metadata,omitempty"`
752752
Spec PolicySpec `json:"spec"`
753-
// status field of the Policy resource
753+
// the status of the Policy resource
754754
Status PolicyStatus `json:"status"`
755755
}
756756

0 commit comments

Comments
 (0)