-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Labels
backlogPull requests/issues that are backlog itemsPull requests/issues that are backlog itemsgoPull requests that update Go codePull requests that update Go code
Milestone
Description
Discussed in #6449
Originally posted by jjngx September 18, 2024
Fix staticcheck
errors:
➜ kubernetes-ingress git:(main) ✗ staticcheck ./...
internal/certmanager/cm_controller.go:63:16: workqueue.RateLimitingInterface is deprecated: Use TypedRateLimitingInterface instead. (SA1019)
internal/certmanager/cm_controller.go:93:35: workqueue.RateLimitingInterface is deprecated: Use TypedRateLimitingInterface instead. (SA1019)
internal/certmanager/cm_controller.go:176:31: workqueue.RateLimitingInterface is deprecated: Use TypedRateLimitingInterface instead. (SA1019)
internal/certmanager/test_files/reactors.go:49:14: type assertion to the same type: createAction.GetObject() already has type runtime.Object (S1040)
internal/externaldns/controller.go:34:16: workqueue.RateLimitingInterface is deprecated: Use TypedRateLimitingInterface instead. (SA1019)
internal/externaldns/controller.go:65:54: workqueue.DefaultControllerRateLimiter is deprecated: Use DefaultTypedControllerRateLimiter instead. (SA1019)
internal/externaldns/controller.go:200:31: workqueue.RateLimitingInterface is deprecated: Use TypedRateLimitingInterface instead. (SA1019)
internal/externaldns/handlers.go:19:36: workqueue.RateLimiter is deprecated: RateLimiter is deprecated, use TypedRateLimiter instead. (SA1019)
internal/externaldns/handlers.go:20:9: workqueue.NewItemExponentialFailureRateLimiter is deprecated: NewItemExponentialFailureRateLimiter is deprecated, use NewTypedItemExponentialFailureRateLimiter instead. (SA1019)
internal/externaldns/handlers.go:26:8: workqueue.RateLimitingInterface is deprecated: Use TypedRateLimitingInterface instead. (SA1019)
internal/k8s/status_test.go:93:17: cache.NewInformer is deprecated: Use NewInformerWithOptions instead. (SA1019)
internal/k8s/status_test.go:153:17: cache.NewInformer is deprecated: Use NewInformerWithOptions instead. (SA1019)
internal/k8s/status_test.go:214:23: cache.NewInformer is deprecated: Use NewInformerWithOptions instead. (SA1019)
internal/k8s/status_test.go:321:23: cache.NewInformer is deprecated: Use NewInformerWithOptions instead. (SA1019)
### UACs
- [ ] Update depricated function calls
- [ ] Add staticcheck to pre-commit
Metadata
Metadata
Assignees
Labels
backlogPull requests/issues that are backlog itemsPull requests/issues that are backlog itemsgoPull requests that update Go codePull requests that update Go code