-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Labels
proposalAn issue that proposes a feature requestAn issue that proposes a feature requestready for refinementAn issue that was triaged and it is ready to be refinedAn issue that was triaged and it is ready to be refined
Milestone
Description
Definition of Done
Development
- Unit tests are written to cover functionality delivered in the story.
- Make sure that the unit test passes before creating a pull request.
- Make sure that the test coverage stays optimal.
- Run
make lint
locally before creating a PR.
Testing
- NIC starts and runs
- NIC starts and runs (with the
service insight
andhealthcheck
options enabled) - Automated tests are written as part of the story.
- Run “make lint-python“ from root
- Acceptance criteria are met.
- Stories are demonstrated to the team.
- Product Manager accepts the story as done.
- If a feature requires changes/extensions of the Helm chart, those shall be done as part of the story.
Release Notes & Documentation
- PR is labeled appropriately so they display in GitHub release notes.
- Create/update documentation related to the user story.
- Create/update the example in our codebase when applicable.
Metadata
Metadata
Assignees
Labels
proposalAn issue that proposes a feature requestAn issue that proposes a feature requestready for refinementAn issue that was triaged and it is ready to be refinedAn issue that was triaged and it is ready to be refined