[Bug]: Creation of Lease in helm chart is superfluous and creates warning in ArgoCD

[hafe]

Version

4.0.1

What Kubernetes platforms are you running on?

Kind

Steps to reproduce

Deploy NIC using the Helm chart, leader election enabled with an ArgoCD application.

ArgoCD will forever show a warning "ExcludedResourceWarning Resource coordination.k8s.io/Lease mylease is excluded in the settings" and ArgoCD will not create/refuse the Lease resource.

It seems to be consensus that Lease resources should be created in runtime and not by manifests. A simple test deploying the helm chart in kind reveals that the Lease object is already created in runtime by NIC! So I suggest to remove the Lease from the helm chart.

References:

• How to have ArgoCD manage lifecycle of Lease resource argoproj/argo-cd#12722
• Can't deploy Linkerd v2.13.x with ArgoCD linkerd/linkerd2#10762

[github-actions]

Hi @hafe thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

[vepatel]

@hafe is this specific to ArgoCD? haven't came across this in normal helm or manifest deployments. Having lease in helm templates allows it to manage them.

[hafe]

I only have experience with ArgoCD where they seem to have made up their mind that Leases are runtime objects.
As I described, NIC helm chart works fine without it. I guess the Kubernetes library or something creates the Lease object automatically. Removing Leases from helm is what other projects seems have done.

[hafe]

I looked at the helm chart for nginx-fabric, it does not have a Lease resource.

[vepatel]

yep we added it in nginx-ingress so helm can manage it and also remove it once the application is uninstalled

[hafe]

But as the issue says, it's superfluous and other projects don't have such resource. They have removed it after their users move to gitops specifically argocd