Skip to content

Conversation

@aknot242
Copy link
Contributor

Proposed changes

There are a number of missing violations in the ApPolicy CRD preventing users from referencing them in an ApPolicy CR. Fixes #7721

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@aknot242 aknot242 requested a review from a team as a code owner April 29, 2025 18:46
@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@aknot242
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

@vepatel
Copy link
Contributor

vepatel commented Apr 30, 2025

@aknot242 can you please run make update-crds from project root and commit the updated files

@aknot242
Copy link
Contributor Author

@vepatel thanks for the reminder. Done.

vepatel
vepatel previously approved these changes May 19, 2025
@aknot242 aknot242 force-pushed the add-missing-violations branch from 5de339f to adb2b36 Compare May 19, 2025 12:54
@aknot242 aknot242 force-pushed the add-missing-violations branch from adb2b36 to 437345d Compare May 20, 2025 11:50
@vepatel vepatel dismissed their stale review May 22, 2025 16:05

needs reconfirmation

@brianehlert brianehlert added backlog Pull requests/issues that are backlog items area/security Issues related to security capabilities or concerns labels Jul 31, 2025
@brianehlert brianehlert added this to the v.5.3.0 milestone Jul 31, 2025
@pdabelf5
Copy link
Collaborator

@aknot242 Can you confirm if this is still required now that #8093 is merged?

@aknot242
Copy link
Contributor Author

This has been addressed. Closing this PR.

@aknot242 aknot242 closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/security Issues related to security capabilities or concerns backlog Pull requests/issues that are backlog items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ApPolicy CRD missing violations

6 participants