[Bug]: stream snippets enumeration is not guarded by an "if"

[javorszky]

Version

edge

What Kubernetes platforms are you running on?

Kind

Steps to reproduce

While looking into something different, I noticed that the http block in the nginx templates have the http snippet range guarded behind an if, but the stream block doesn't guard the stream snippets evaluation behind an if

HTTP:

• https://github.com/nginx/kubernetes-ingress/blob/main/internal/configs/version1/nginx.tmpl#L39-L42
• https://github.com/nginx/kubernetes-ingress/blob/main/internal/configs/version1/nginx-plus.tmpl#L45-L48

Stream:

• https://github.com/nginx/kubernetes-ingress/blob/main/internal/configs/version1/nginx.tmpl#L252-L253
• https://github.com/nginx/kubernetes-ingress/blob/main/internal/configs/version1/nginx-plus.tmpl#L311-L312

We need to double check whether we need the if, and if so, add it to stream too. If not, we can remove it from http.

Potential step to bump into a render issue: have a CRD with a stream snippet key present with empty value.

[github-actions]

Hi @javorszky thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!