-
Notifications
You must be signed in to change notification settings - Fork 2k
Open
Labels
backlogPull requests/issues that are backlog itemsPull requests/issues that are backlog itemshelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesproposalAn issue that proposes a feature requestAn issue that proposes a feature request
Description
Is your feature request related to a problem? Please describe.
Add support to loadBalancerClass on nginx service
Describe the solution you'd like
We use Antrea as our CNI, and we need to include the field loadbalancerClass: antrea in our services of type loadbalance.
Can you include it in helm templates/controller-service.yaml
Service Sample:
apiVersion: v1
kind: Service
metadata:
name: nginx-ingress
annotations:
service.antrea.io/external-ip-pool: "myexternalpool"
spec:
externalTrafficPolicy: Local
type: LoadBalancer
loadBalancerIP: 192.168.0.1
loadBalancerClass: antrea
This can be achieved in this block here:
templates/controller-service.yaml
{{- if .Values.controller.service.loadBalancerClass }}
loadBalancerClass: {{ .Values.controller.service.loadBalancerClass }}
{{- end }}
values.schema.json also should be changed:
"loadBalancerClass": {
"default": "",
"title": "The loadBalancerClass",
"$ref": "https://raw.githubusercontent.com/nginxinc/kubernetes-json-schema/master/v1.33.1/_definitions.json#/definitions/io.k8s.api.core.v1.ServiceSpec/properties/loadBalancerClass"
},
Additional context
(#8435)
If needed, I can submit the PR with those changes
pdabelf5
Metadata
Metadata
Assignees
Labels
backlogPull requests/issues that are backlog itemsPull requests/issues that are backlog itemshelp wantedIssues identified as good community contribution opportunitiesIssues identified as good community contribution opportunitiesproposalAn issue that proposes a feature requestAn issue that proposes a feature request
Type
Projects
Status
Todo β