-
Notifications
You must be signed in to change notification settings - Fork 2k
Support loadBalancerClass in Helm chart #8555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Support loadBalancerClass in Helm chart #8555
Conversation
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
|
I have hereby read the F5 CLA and agree to its terms |
48538f5 to
9898915
Compare
|
Tests: value.yaml: tested with valueshelm install tst1 ./charts/nginx-ingress/ -f value.yaml: result: tested with no values:helm install tst ./charts/nginx-ingress/ result: |
|
It would be great if you can include your test results in the helm tests https://github.com/nginx/kubernetes-ingress/blob/main/charts/tests/helmunit_test.go |
for more information, see https://pre-commit.ci
I added the test, i didn't find a doc to guide how to add tests, but I think I did it right. Can you double-check to make sure everything is alright? After adding tests, I ran: Result: |
|
Thanks @rodrigosandrin for adding these! No docs on how to do tests but what you have done looks good! We will review when we have a chance! |
Proposed changes
Add support to loadBalancerClass in helm chart.
Issue:
#8441
Checklist
Before creating a PR, run through this checklist and mark each as complete.