[Bug]: (Helm chart) nodeport setting causes argoCD out-of-sync

[josemaia]

Version

5.3.0

What Kubernetes platforms are you running on?

EKS Amazon

Steps to reproduce

1. Download the helm chart (2.4.2) into a folder
2. Run helm template -s templates/controller-service.yaml
3. Observe that with default values the nodePorts will show up as empty

         - port: 443
           targetPort: 443
           protocol: TCP
           name: https
           nodePort:

4: If using a tool like ArgoCD to maintain this manifest via GitOps, this causes persistent diffs / out of sync state as it will notice a difference from the empty nodePort to the the ports "injected" by spec.allocateLoadBalancerNodePorts

Fix suggestion would be setting a check for emptiness that omits this field, which is what kubernetes/ingress-nginx does:

{{- if and (or (eq .Values.controller.service.type "LoadBalancer") (eq .Values.controller.service.type "NodePort")) (not (empty .Values.controller.service.httpsPort.nodePort)) }}

[github-actions]

Hi @josemaia thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!