Skip to content

Refactor special secret input and validation #6808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 14, 2024
Merged

Refactor special secret input and validation #6808

merged 5 commits into from
Nov 14, 2024

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Nov 14, 2024 •
edited
Loading

Proposed changes

Refactor special secrets in LoadBalancerController to take a struct for the secrets. This will remove code duplication when we expand the logic for plus mgmt secrets.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner November 14, 2024 10:34
@github-actions github-actions bot added the go Pull requests that update Go code label Nov 14, 2024
@codecov
Copy link

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 17.85714% with 23 lines in your changes missing coverage. Please review.

Project coverage is 53.46%. Comparing base (214d9f1) to head (eb14d5c).
Report is 84 commits behind head on main.

Files with missing lines Patch % Lines
internal/k8s/controller.go 18.51% 22 Missing ⚠️
internal/configs/configurator.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6808      +/-   ##
==========================================
- Coverage   53.46%   53.46%   -0.01%     
==========================================
  Files          89       88       -1     
  Lines       20218    20211       -7     
==========================================
- Hits        10809    10805       -4     
+ Misses       8965     8962       -3     
  Partials      444      444

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 merged commit 0db9f89 into main Nov 14, 2024
82 checks passed
@pdabelf5 pdabelf5 deleted the special-secrets branch November 14, 2024 14:15
@pdabelf5 pdabelf5 mentioned this pull request Nov 20, 2024
Merged
6 tasks
@pdabelf5 pdabelf5 added chore Pull requests for routine tasks and removed go Pull requests that update Go code labels Dec 16, 2024
@pdabelf5 pdabelf5 changed the title refactor special secret input and validation Refactor special secret input and validation Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@jjngx jjngx jjngx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

chore Pull requests for routine tasks

Projects

NGINX Ingress Controller
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pdabelf5 @j1m-ryan @jjngx