Skip to content

Remove support for Open Tracing for NGINX Plus #7567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 3, 2025
Merged

Remove support for Open Tracing for NGINX Plus #7567

merged 12 commits into from
Apr 3, 2025

Conversation

@jjngx
Copy link
Contributor

@jjngx jjngx commented Mar 26, 2025 •
edited by haywoodsh
Loading

Proposed changes

  • Remove Open Tracing support for Plus, return error if the configmap key opentracing is set to true and Plus is used
  • disable Open Tracing for OSS if either tracer or tracer-config is missing

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added go Pull requests that update Go code docker Pull requests that update Docker code labels Mar 26, 2025
@codecov
Copy link

codecov bot commented Mar 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.11%. Comparing base (44a1173) to head (e421fca).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
internal/configs/configmaps.go 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7567      +/-   ##
==========================================
+ Coverage   52.06%   52.11%   +0.04%     
==========================================
  Files          89       89              
  Lines       21312    21320       +8     
==========================================
+ Hits        11096    11110      +14     
+ Misses       9746     9741       -5     
+ Partials      470      469       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pdabelf5 pdabelf5 mentioned this pull request Apr 2, 2025
Merged
6 tasks
@github-actions github-actions bot added documentation Pull requests/issues for documentation dependencies Pull requests that update a dependency file python Pull requests that update Python code github_actions Pull requests that update Github_actions code labels Apr 2, 2025
@haywoodsh haywoodsh force-pushed the chore/no-opentracing branch from 9c2cda6 to fca5f92 Compare April 2, 2025 13:48
@github-actions github-actions bot removed documentation Pull requests/issues for documentation dependencies Pull requests that update a dependency file python Pull requests that update Python code github_actions Pull requests that update Github_actions code labels Apr 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7567/

@haywoodsh haywoodsh force-pushed the chore/no-opentracing branch 4 times, most recently from 32b2981 to d36429e Compare April 2, 2025 15:22
@haywoodsh haywoodsh changed the title Don't configure OpenTracing Remove support for Open Tracing for NGINX Plus Apr 2, 2025
@haywoodsh haywoodsh force-pushed the chore/no-opentracing branch from e421fca to 7550180 Compare April 2, 2025 16:26
@haywoodsh haywoodsh marked this pull request as ready for review April 2, 2025 16:46
@haywoodsh haywoodsh requested a review from a team as a code owner April 2, 2025 16:46
@haywoodsh haywoodsh merged commit 24bf43c into main Apr 3, 2025
79 checks passed
@haywoodsh haywoodsh deleted the chore/no-opentracing branch April 3, 2025 11:01
pdabelf5 pushed a commit that referenced this pull request Apr 3, 2025
@jjngx @haywoodsh @pdabelf5
Remove OpenTracing Module for NGINX Plus R34 (#7567)
aac7917 
* remove nginx plus opentracing module, reject opentracing configmap key if nginxplus flag is set to true

Signed-off-by: Haywood Shannon <[email protected]>
Co-authored-by: Haywood Shannon <[email protected]>
@pdabelf5 pdabelf5 added enhancement Pull requests for new features/feature enhancements and removed go Pull requests that update Go code docker Pull requests that update Docker code labels Apr 4, 2025
@pdabelf5 pdabelf5 added change Pull requests that introduce a change and removed enhancement Pull requests for new features/feature enhancements labels Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javorszky javorszky javorszky approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees

No one assigned

Labels

change Pull requests that introduce a change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jjngx @javorszky @pdabelf5 @haywoodsh