From b3510a70e8a9ab1a8d33ca26b4e5c6a98b195bbd Mon Sep 17 00:00:00 2001 From: Alex Fenlon Date: Mon, 1 Dec 2025 13:56:13 +0000 Subject: [PATCH 1/2] Fix spacing in README table --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index ff2cea8370..4cd3ff550d 100644 --- a/README.md +++ b/README.md @@ -141,8 +141,8 @@ It is important that the versions of those things above match. The table below summarizes the options regarding the images, Helm chart, manifests, documentation and examples and gives your links to the correct versions: -| Version | Description | Image for NGINX | Image for NGINX Plus | Installation Manifests and Helm Chart | Documentation and Examples | -| ------- | ----------- | --------------- | -------------------- | ---------------------------------------| -------------------------- | +| Version | Description | Image for NGINX | Image for NGINX Plus | Installation Manifests and Helm Chart | Documentation and Examples | +| ------- | ----------- | --------------- | -------------------- | --------------------------------------- | -------------------------- | | Latest stable release | For production use | Use the 5.2.1 images from [DockerHub](https://hub.docker.com/r/nginx/nginx-ingress/), [GitHub Container](https://github.com/nginx/kubernetes-ingress/pkgs/container/kubernetes-ingress), [Amazon ECR Public Gallery](https://gallery.ecr.aws/nginx/nginx-ingress) or [Quay.io](https://quay.io/repository/nginx/nginx-ingress) or [build your own image](https://docs.nginx.com/nginx-ingress-controller/install/build/). | Use the 5.2.1 images from the [F5 Container Registry](https://docs.nginx.com/nginx-ingress-controller/install/images/registry-download/) or [Build your own image](https://docs.nginx.com/nginx-ingress-controller/install/build). | [Manifests](https://github.com/nginx/kubernetes-ingress/tree/v5.2.1/deployments). [Helm chart](https://github.com/nginx/kubernetes-ingress/tree/v5.2.1/charts/nginx-ingress). | [Documentation](https://docs.nginx.com/nginx-ingress-controller/). [Examples](https://docs.nginx.com/nginx-ingress-controller/configuration/configuration-examples/). | | Edge/Nightly | For testing and experimenting | Use the edge or nightly images from [DockerHub](https://hub.docker.com/r/nginx/nginx-ingress/), [GitHub Container](https://github.com/nginx/kubernetes-ingress/pkgs/container/kubernetes-ingress), [Amazon ECR Public Gallery](https://gallery.ecr.aws/nginx/nginx-ingress) or [Quay.io](https://quay.io/repository/nginx/nginx-ingress) or [build your own image](https://docs.nginx.com/nginx-ingress-controller/install/build/). | [Build your own image](https://docs.nginx.com/nginx-ingress-controller/install/build/). | [Manifests](https://github.com/nginx/kubernetes-ingress/tree/main/deployments). [Helm chart](https://github.com/nginx/kubernetes-ingress/tree/main/charts/nginx-ingress). | [Documentation](https://docs.nginx.com/nginx-ingress-controller). [Examples](https://github.com/nginx/kubernetes-ingress/tree/main/examples). | From b9bbfc095cc419d9b1e4b4a6bed64b8a31a2f624 Mon Sep 17 00:00:00 2001 From: Alex Fenlon Date: Mon, 1 Dec 2025 14:02:19 +0000 Subject: [PATCH 2/2] fix: lint tests/README.md --- tests/README.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/README.md b/tests/README.md index 5c657f9f57..0f5e03e068 100644 --- a/tests/README.md +++ b/tests/README.md @@ -98,7 +98,6 @@ The tests will use the NGINX Ingress Controller with the default `nginx/nginx-in The test suite includes several additional make targets for cluster management and cleanup: - - `make create-mini-cluster` - Create a Minikube K8S cluster - `make delete-mini-cluster` - Delete a Minikube K8S cluster - `make run-tests-in-minikube` - Run tests in Minikube @@ -121,8 +120,8 @@ The table below shows various configuration options for the tests. If you use Py | `--image-pull-policy` | `PULL_POLICY` | The pull policy of the Ingress Controller image. | `IfNotPresent` | | `--deployment-type` | `DEPLOYMENT_TYPE` | The type of the IC deployment: deployment, daemon-set or stateful-set. | `deployment` | | `--ic-type` | `IC_TYPE` | The type of the Ingress Controller: nginx-ingress or nginx-plus-ingress. | `nginx-ingress` | -| `--service` | `SERVICE`, not supported by `run-tests-in-kind` target. | The type of the Ingress Controller service: nodeport or loadbalancer. | `nodeport` | -| `--node-ip` | `NODE_IP`, not supported by `run-tests-in-kind` target. | The public IP of a cluster node. Not required if you use the loadbalancer service (see --service argument). | `""` | +| `--service` | `SERVICE`, not supported by `run-tests-in-kind` target. | The type of the Ingress Controller service: nodeport or loadbalancer. | `nodeport` | +| `--node-ip` | `NODE_IP`, not supported by `run-tests-in-kind` target. | The public IP of a cluster node. Not required if you use the loadbalancer service (see --service argument). | `""` | | `--kubeconfig` | `N/A` | An absolute path to a kubeconfig file. | `~/.kube/config` or the value of the `KUBECONFIG` env variable | | `N/A` | `KUBE_CONFIG_FOLDER`, not supported by `run-tests-in-kind` target. | A path to a folder with a kubeconfig file. | `~/.kube/` | | `--show-ic-logs` | `SHOW_IC_LOGS` | A flag to control accumulating IC logs in stdout. | `no` |