Don't use default http client

Author: sjberman

tests/framework/request.go

@@ -56,12 +56,12 @@ func makeRequest(
 ) (*http.Response, error) {
 	dialer := &net.Dialer{}
 
-	baseTransport, ok := http.DefaultTransport.(*http.Transport)
+	transport, ok := http.DefaultTransport.(*http.Transport)
 	if !ok {
 		return nil, errors.New("transport is not of type *http.Transport")
 	}
 
-	customTransport := baseTransport.Clone()
+	customTransport := transport.Clone()
 	customTransport.DialContext = func(
 		ctx context.Context,
 		network,
@@ -94,21 +94,13 @@ func makeRequest(
 
 	var resp *http.Response
 	if strings.HasPrefix(url, "https") {
-		transport, ok := http.DefaultTransport.(*http.Transport)
-		if !ok {
-			return nil, errors.New("transport is not of type *http.Transport")
-		}
-
-		customTransport := transport.Clone()
 		// similar to how in our examples with https requests we run our curl command
 		// we turn off verification of the certificate, we do the same here
 		customTransport.TLSClientConfig = &tls.Config{InsecureSkipVerify: true} //nolint:gosec // for https test traffic
-		client := &http.Client{Transport: customTransport}
-		resp, err = client.Do(req)
-	} else {
-		resp, err = http.DefaultClient.Do(req)
 	}
 
+	client := &http.Client{Transport: customTransport}
+	resp, err = client.Do(req)
 	if err != nil {
 		return nil, err
 	}