Skip to content

Commit 028d3f1

Browse files
authored
Fix NFR workflow input check (#1725)
Problem: The nginx_plus input check was not working and therefore did not create the right variables. Solution: Evaluate the boolean val by removing quotes
1 parent 20d6003 commit 028d3f1

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

.github/workflows/nfr.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,15 +160,15 @@ jobs:
160160
- name: Open a PR with the results
161161
uses: peter-evans/create-pull-request@70a41aba780001da0a30141984ae2a0c95d8704e # v6.0.2
162162
with:
163-
commit-message: NFR Test Results for NGF version ${{ inputs.version }}${{ inputs.nginx_plus == 'true' && '(Plus)' || ''}}
163+
commit-message: NFR Test Results for NGF version ${{ inputs.version }} ${{ inputs.nginx_plus == true && '(Plus)' || ''}}
164164
author: ${{ github.actor }} <${{ github.actor_id }}+${{ github.actor }}@users.noreply.github.com>
165-
branch: tests/nfr-tests-${{ inputs.version }}${{ inputs.nginx_plus == 'true' && '-plus' || ''}}
165+
branch: tests/nfr-tests-${{ inputs.version }}${{ inputs.nginx_plus == true && '-plus' || ''}}
166166
delete-branch: true
167-
title: NFR Test Results for NGF version ${{ inputs.version }}${{ inputs.nginx_plus == 'true' && '(Plus)' || ''}}
167+
title: NFR Test Results for NGF version ${{ inputs.version }} ${{ inputs.nginx_plus == true && '(Plus)' || ''}}
168168
add-paths: |
169169
tests/results/
170170
body: |
171-
Update with NFR test results for NGF version ${{ inputs.version }}${{ inputs.nginx_plus == 'true' && '(Plus)' || ''}}
171+
Update with NFR test results for NGF version ${{ inputs.version }} ${{ inputs.nginx_plus == true && '(Plus)' || ''}}
172172
- Auto-generated by the NFR tests workflow run ${{ github.run_id }}
173173
- Tests ran using Docker image tag ${{ inputs.image_tag }}
174174
- ${{ inputs.test_label }} test(s) ran

0 commit comments

Comments
 (0)