update based on reviews

Author: salonichf5

cmd/gateway/endpoint_picker.go

@@ -154,9 +154,11 @@ func buildHeaderRequest(r *http.Request) *extprocv3.ProcessingRequest {
 
 	for key, values := range r.Header {
 		for _, value := range values {
-			// Normalize header keys to lowercase for case-insensitive matching
-			// This fixes the issue where Go's HTTP header normalization (Title-Case)
-			// doesn't match EPP's expected lowercase header keys
+			// Normalize header keys to lowercase for case-insensitive matching.
+			// This addresses the mismatch between Go's default HTTP header normalization (Title-Case)
+			// and EPP's expectation of lowercase header keys. Additionally, HTTP/2 — which gRPC uses —
+			// requires all header field names to be lowercase as specified in RFC 7540, Section 8.1.2:
+			// https://datatracker.ietf.org/doc/html/rfc7540#section-8.1.2
 			normalizedKey := strings.ToLower(key)
 
 			headerMap.Headers = append(headerMap.Headers, &corev3.HeaderValue{

internal/controller/nginx/config/maps.go

@@ -183,7 +183,7 @@ func createAddHeadersMap(name string) shared.Map {
 	}
 }
 
-// buildInferenceMaps creates maps for InferencePool back-ends.
+// buildInferenceMaps creates maps for InferencePool Backends.
 func buildInferenceMaps(groups []dataplane.BackendGroup) []shared.Map {
 	inferenceMaps := make([]shared.Map, 0, len(groups))
 

internal/controller/nginx/config/servers.go

@@ -28,7 +28,6 @@ const (
 	// HeaderMatchSeparator is the separator for constructing header-based match for NJS.
 	HeaderMatchSeparator = ":"
 	rootPath             = "/"
-	svcClusterLocal      = ".svc.cluster.local"
 )
 
 var grpcAuthorityHeader = http.Header{
@@ -461,7 +460,7 @@ func createInternalLocationsForRule(
 					}
 					intInfLocation.EPPInternalPath = intLocation.Path
 					if b.EndpointPickerConfig.NsName != "" {
-						intInfLocation.EPPHost = string(eppRef.Name) + "." + b.EndpointPickerConfig.NsName + svcClusterLocal
+						intInfLocation.EPPHost = string(eppRef.Name) + "." + b.EndpointPickerConfig.NsName
 					} else {
 						intInfLocation.EPPHost = string(eppRef.Name)
 					}
@@ -521,7 +520,7 @@ func createInferenceLocationsForRule(
 					}
 					extLocations[i].EPPInternalPath = intLocation.Path
 					if b.EndpointPickerConfig.NsName != "" {
-						extLocations[i].EPPHost = string(eppRef.Name) + "." + b.EndpointPickerConfig.NsName + svcClusterLocal
+						extLocations[i].EPPHost = string(eppRef.Name) + "." + b.EndpointPickerConfig.NsName
 					} else {
 						extLocations[i].EPPHost = string(eppRef.Name)
 					}

internal/controller/nginx/config/servers_template.go

@@ -124,17 +124,16 @@ server {
         {{- end }}
 
         {{- if contains $l.Type "inference" -}}
-            if ($request_method = GET) {
-                set $inference_workload_endpoint "";
-                rewrite ^ {{ $l.EPPInternalPath }} last;
-            }
-
-            js_var $inference_workload_endpoint;
-            set $epp_internal_path {{ $l.EPPInternalPath }};
-            set $epp_host          {{ $l.EPPHost }};
-            set $epp_port          {{ $l.EPPPort }};
-            js_content epp.getEndpoint;
-            break;
+        if ($request_method = GET) {
+            set $inference_workload_endpoint "";
+            rewrite ^ {{ $l.EPPInternalPath }} last;
+        }
+
+        js_var $inference_workload_endpoint;
+        set $epp_internal_path {{ $l.EPPInternalPath }};
+        set $epp_host          {{ $l.EPPHost }};
+        set $epp_port          {{ $l.EPPPort }};
+        js_content epp.getEndpoint;
         {{- end }}
 
         {{ $proxyOrGRPC := "proxy" }}{{ if $l.GRPC }}{{ $proxyOrGRPC = "grpc" }}{{ end }}

tests/conformance/conformance_test.go

@@ -22,16 +22,15 @@ import (
 	"testing"
 
 	. "github.com/onsi/gomega"
-	"gopkg.in/yaml.v2"
+	inference_conformance "sigs.k8s.io/gateway-api-inference-extension/conformance"
 	v1 "sigs.k8s.io/gateway-api/apis/v1"
 	"sigs.k8s.io/gateway-api/apis/v1beta1"
 	"sigs.k8s.io/gateway-api/conformance"
 	conf_v1 "sigs.k8s.io/gateway-api/conformance/apis/v1"
 	"sigs.k8s.io/gateway-api/conformance/tests"
 	"sigs.k8s.io/gateway-api/conformance/utils/flags"
 	"sigs.k8s.io/gateway-api/conformance/utils/suite"
-
-	inference_conformance "sigs.k8s.io/gateway-api-inference-extension/conformance"
+	"sigs.k8s.io/yaml"
 )
 
 const (
@@ -92,7 +91,6 @@ func TestConformance(t *testing.T) {
 }
 
 func TestInferenceExtensionConformance(t *testing.T) {
-
 	t.Logf(`Running inference conformance tests with %s GatewayClass\n cleanup: %t\n`+
 		`debug: %t\n enable all features: %t \n supported extended features: [%v]\n exempt features: [%v]\n`+
 		`skip tests: [%v]`,