Ensure installed resources are only delete if an error is NOT expected

Author: shaun-nx

tests/Makefile

@@ -192,7 +192,6 @@ uninstall-ngf: ## Uninstall NGF on configured kind cluster
 .PHONY: test-cel-validation
 test-cel-validation:
 	-make install-crds || true;
-	-make install-gateway-crds || true;
 	@if [ -z "$(CEL_TEST_TARGET)" ]; then \
 		echo "Running all tests in ./cel"; \
 		go test -v ./cel; \

tests/cel/common.go

@@ -100,15 +100,14 @@ func validateCrd(t *testing.T, wantErrors []string, crd client.Object, k8sClient
 	defer cancel()
 	err := k8sClient.Create(ctx, crd)
 
-	// Clean up after test
-	defer func() {
-		deleteErr = k8sClient.Delete(ctx, crd)
-	}()
-	g.Expect(deleteErr).ToNot(HaveOccurred())
-
 	// Check for expected errors
 	if len(wantErrors) == 0 {
 		g.Expect(err).ToNot(HaveOccurred())
+		// Clean up after test
+		defer func() {
+			deleteErr = k8sClient.Delete(ctx, crd)
+			g.Expect(deleteErr).ToNot(HaveOccurred())
+		}()
 	} else {
 		g.Expect(err).To(HaveOccurred())
 		for _, wantError := range wantErrors {