Add test for when minReplicas is nil

Author: shaun-nx

tests/Makefile

@@ -191,6 +191,7 @@ uninstall-ngf: ## Uninstall NGF on configured kind cluster
 # Run CEL validation integration tests against a real cluster
 .PHONY: test-cel-validation
 test-cel-validation:
+	-make install-crds || true;
 	-make install-gateway-crds || true;
 	@if [ -z "$(CEL_TEST_TARGET)" ]; then \
 		echo "Running all tests in ./cel"; \

tests/cel/common.go

@@ -63,11 +63,8 @@ func getKubernetesClient(t *testing.T) (k8sClient client.Client) {
 
 	// Set up scheme with NGF types
 	scheme := runtime.NewScheme()
-	err = ngfAPIv1alpha1.AddToScheme(scheme)
-	g.Expect(err).ToNot(HaveOccurred())
-
-	err = ngfAPIv1alpha2.AddToScheme(scheme)
-	g.Expect(err).ToNot(HaveOccurred())
+	g.Expect(ngfAPIv1alpha1.AddToScheme(scheme)).To(Succeed())
+	g.Expect(ngfAPIv1alpha2.AddToScheme(scheme)).To(Succeed())
 
 	k8sClient, err = client.New(k8sConfig, client.Options{Scheme: scheme})
 	g.Expect(err).ToNot(HaveOccurred())
@@ -96,8 +93,8 @@ func validateCrd(t *testing.T, wantErrors []string, crd client.Object, k8sClient
 	g := NewWithT(t)
 	timeoutConfig := framework.DefaultTimeoutConfig()
 	ctx, cancel := context.WithTimeout(context.Background(), timeoutConfig.KubernetesClientTimeout)
-	err := k8sClient.Create(ctx, crd)
 	defer cancel()
+	err := k8sClient.Create(ctx, crd)
 
 	// Clean up after test
 	defer func() {

tests/cel/nginxproxy_test.go

@@ -165,6 +165,19 @@ func TestNginxProxyAutoscaling(t *testing.T) {
 				},
 			},
 		},
+		{
+			name: "Validate NginxProxy is valid when MinReplicas is nil",
+			spec: ngfAPIv1alpha2.NginxProxySpec{
+				Kubernetes: &ngfAPIv1alpha2.KubernetesSpec{
+					Deployment: &ngfAPIv1alpha2.DeploymentSpec{
+						Autoscaling: &ngfAPIv1alpha2.AutoscalingSpec{
+							MinReplicas: nil,
+							MaxReplicas: 5,
+						},
+					},
+				},
+			},
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {