Update dependency golangci/golangci-lint to v2.5.0 (#3940)

renovate[bot] · ciarams87 · web-flow · commit 24dee2b748be · 2025-09-22T14:09:38.000+01:00
* Update dependency golangci/golangci-lint to v2.5.0

| datasource  | package                | from   | to     |
| ----------- | ---------------------- | ------ | ------ |
| github-tags | golangci/golangci-lint | v2.4.0 | v2.5.0 |


Signed-off-by: renovate[bot] &lt;29139614+renovate[bot]@users.noreply.github.com&gt;

* Fix lint errors

---------

Signed-off-by: renovate[bot] &lt;29139614+renovate[bot]@users.noreply.github.com&gt;
Co-authored-by: renovate[bot] &lt;29139614+renovate[bot]@users.noreply.github.com&gt;
Co-authored-by: Ciara Stacke &lt;c.stacke@f5.com&gt;
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
@@ -50,7 +50,7 @@ jobs:
         uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0
         with:
           working-directory: ${{ matrix.directory }}
-          version: v2.4.0 # renovate: datasource=github-tags depName=golangci/golangci-lint
+          version: v2.5.0 # renovate: datasource=github-tags depName=golangci/golangci-lint
 
   njs-lint:
     name: NJS Lint
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -39,7 +39,7 @@ repos:
           - javascript
 
   - repo: https://github.com/golangci/golangci-lint
-    rev: v2.4.0
+    rev: v2.5.0
     hooks:
       - id: golangci-lint-full
         name: golangci-lint-root
diff --git a/Makefile b/Makefile
@@ -23,7 +23,7 @@ GO_LINKER_FLAGS = $(GO_LINKER_FLAGS_OPTIMIZATIONS) $(GO_LINKER_FlAGS_VARS)
 
 # tools versions
 # renovate: datasource=github-tags depName=golangci/golangci-lint
-GOLANGCI_LINT_VERSION = v2.4.0
+GOLANGCI_LINT_VERSION = v2.5.0
 # renovate: datasource=docker depName=kindest/node
 KIND_K8S_VERSION = v1.34.0
 # renovate: datasource=github-tags depName=norwoodj/helm-docs
diff --git a/cmd/gateway/commands.go b/cmd/gateway/commands.go
@@ -776,7 +776,7 @@ func getBuildInfo() (commitHash string, commitTime string, dirtyBuild string) {
 
 	info, ok := debug.ReadBuildInfo()
 	if !ok {
-		return
+		return commitHash, commitTime, dirtyBuild
 	}
 	for _, kv := range info.Settings {
 		switch kv.Key {
@@ -789,7 +789,7 @@ func getBuildInfo() (commitHash string, commitTime string, dirtyBuild string) {
 		}
 	}
 
-	return
+	return commitHash, commitTime, dirtyBuild
 }
 
 func createGatewayPodConfig(version, svcName string) (config.GatewayPodConfig, error) {
diff --git a/tests/framework/info.go b/tests/framework/info.go
@@ -66,7 +66,7 @@ func GetBuildInfo() (commitHash string, commitTime string, dirtyBuild string) {
 
 	info, ok := debug.ReadBuildInfo()
 	if !ok {
-		return
+		return commitHash, commitTime, dirtyBuild
 	}
 
 	for _, kv := range info.Settings {
@@ -80,7 +80,7 @@ func GetBuildInfo() (commitHash string, commitTime string, dirtyBuild string) {
 		}
 	}
 
-	return
+	return commitHash, commitTime, dirtyBuild
 }
 
 // AddNginxLogsAndEventsToReport adds nginx logs and events from the namespace to the report if the spec failed.

Original file line number	Diff line number	Diff line change
`@@ -776,7 +776,7 @@ func getBuildInfo() (commitHash string, commitTime string, dirtyBuild string) {`
`776`	`776`
`777`	`777`	`info, ok := debug.ReadBuildInfo()`
`778`	`778`	`if !ok {`
`779`		`- return`
	`779`	`+ return commitHash, commitTime, dirtyBuild`
`780`	`780`	`}`
`781`	`781`	`for _, kv := range info.Settings {`
`782`	`782`	`switch kv.Key {`
`@@ -789,7 +789,7 @@ func getBuildInfo() (commitHash string, commitTime string, dirtyBuild string) {`
`789`	`789`	`}`
`790`	`790`	`}`
`791`	`791`
`792`		`- return`
	`792`	`+ return commitHash, commitTime, dirtyBuild`
`793`	`793`	`}`
`794`	`794`
`795`	`795`	`func createGatewayPodConfig(version, svcName string) (config.GatewayPodConfig, error) {`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ func GetBuildInfo() (commitHash string, commitTime string, dirtyBuild string) {`
`66`	`66`
`67`	`67`	`info, ok := debug.ReadBuildInfo()`
`68`	`68`	`if !ok {`
`69`		`- return`
	`69`	`+ return commitHash, commitTime, dirtyBuild`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`for _, kv := range info.Settings {`
`@@ -80,7 +80,7 @@ func GetBuildInfo() (commitHash string, commitTime string, dirtyBuild string) {`
`80`	`80`	`}`
`81`	`81`	`}`
`82`	`82`
`83`		`- return`
	`83`	`+ return commitHash, commitTime, dirtyBuild`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`// AddNginxLogsAndEventsToReport adds nginx logs and events from the namespace to the report if the spec failed.`