Add tests for RequestTimeout CEL validation

Author: shaun-nx

tests/cel/clientsettingspolicy_test.go

@@ -10,6 +10,7 @@ import (
 	gatewayv1alpha2 "sigs.k8s.io/gateway-api/apis/v1alpha2"
 
 	ngfAPIv1alpha1 "github.com/nginx/nginx-gateway-fabric/v2/apis/v1alpha1"
+	"github.com/nginx/nginx-gateway-fabric/v2/internal/framework/helpers"
 	"github.com/nginx/nginx-gateway-fabric/v2/tests/framework"
 )
 
@@ -129,6 +130,66 @@ func TestClientSettingsPoliciesTargetRefGroup(t *testing.T) {
 	}
 }
 
+func TestClientSettingsPoliciesKeepAliveTimeout(t *testing.T) {
+	t.Parallel()
+	g := NewWithT(t)
+	k8sClient, err := getKubernetesClient(t)
+	g.Expect(err).ToNot(HaveOccurred())
+	tests := []struct {
+		policySpec ngfAPIv1alpha1.ClientSettingsPolicySpec
+		name       string
+		wantErrors []string
+	}{
+		{
+			name: "Validate KeepAliveTimeout is not set",
+			policySpec: ngfAPIv1alpha1.ClientSettingsPolicySpec{
+				TargetRef: gatewayv1alpha2.LocalPolicyTargetReference{
+					Kind:  gatewayKind,
+					Group: gatewayGroup,
+				},
+				KeepAlive: nil,
+			},
+		},
+		{
+			name: "Validate KeepAlive is set",
+			policySpec: ngfAPIv1alpha1.ClientSettingsPolicySpec{
+				TargetRef: gatewayv1alpha2.LocalPolicyTargetReference{
+					Kind:  gatewayKind,
+					Group: gatewayGroup,
+				},
+				KeepAlive: &ngfAPIv1alpha1.ClientKeepAlive{
+					Timeout: &ngfAPIv1alpha1.ClientKeepAliveTimeout{
+						Server: helpers.GetPointer[ngfAPIv1alpha1.Duration]("5s"),
+						Header: helpers.GetPointer[ngfAPIv1alpha1.Duration]("2s"),
+					},
+				},
+			},
+		},
+		{
+			name:       "Validate Header cannot be set without Server",
+			wantErrors: []string{expectedHeaderWithoutServerError},
+			policySpec: ngfAPIv1alpha1.ClientSettingsPolicySpec{
+				TargetRef: gatewayv1alpha2.LocalPolicyTargetReference{
+					Kind:  gatewayKind,
+					Group: gatewayGroup,
+				},
+				KeepAlive: &ngfAPIv1alpha1.ClientKeepAlive{
+					Timeout: &ngfAPIv1alpha1.ClientKeepAliveTimeout{
+						Header: helpers.GetPointer[ngfAPIv1alpha1.Duration]("2s"),
+					},
+				},
+			},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+			validateClientSettingsPolicy(t, tt, g, k8sClient)
+		})
+	}
+}
+
 func validateClientSettingsPolicy(t *testing.T, tt struct {
 	policySpec ngfAPIv1alpha1.ClientSettingsPolicySpec
 	name       string

tests/cel/common.go

@@ -28,8 +28,9 @@ const (
 )
 
 const (
-	expectedTargetRefKindError  = `TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute`
-	expectedTargetRefGroupError = `TargetRef Group must be gateway.networking.k8s.io.`
+	expectedTargetRefKindError       = `TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute`
+	expectedTargetRefGroupError      = `TargetRef Group must be gateway.networking.k8s.io.`
+	expectedHeaderWithoutServerError = `header can only be specified if server is specified`
 )
 
 const (