Add unit test for ParseNginxSize

Author: ciarams87

internal/controller/nginx/config/policies/proxysettings/validator.go

@@ -130,14 +130,14 @@ func validateBusyBufferSizeRelationships(buffering ngfAPI.ProxyBuffering, fieldP
 		return nil
 	}
 
-	busyBuffersSize, err := parseNginxSize(string(*buffering.BusyBuffersSize))
+	busyBuffersSize, err := ParseNginxSize(string(*buffering.BusyBuffersSize))
 	if err != nil {
 		return nil // Skip validation if size is invalid (will be caught by other validation)
 	}
 
 	// Validate: busyBuffersSize > bufferSize
 	if buffering.BufferSize != nil {
-		bufferSize, err := parseNginxSize(string(*buffering.BufferSize))
+		bufferSize, err := ParseNginxSize(string(*buffering.BufferSize))
 		if err == nil && busyBuffersSize <= bufferSize {
 			path := fieldPath.Child("busyBuffersSize")
 			allErrs = append(allErrs, field.Invalid(
@@ -150,7 +150,7 @@ func validateBusyBufferSizeRelationships(buffering ngfAPI.ProxyBuffering, fieldP
 
 	// Validate: busyBuffersSize < (buffers.number * buffers.size) - buffers.size
 	if buffering.Buffers != nil {
-		buffersSize, err := parseNginxSize(string(buffering.Buffers.Size))
+		buffersSize, err := ParseNginxSize(string(buffering.Buffers.Size))
 		if err == nil {
 			totalBufferSpace := buffersSize * int64(buffering.Buffers.Number)
 			maxBusyBuffersSize := totalBufferSpace - buffersSize
@@ -168,9 +168,9 @@ func validateBusyBufferSizeRelationships(buffering ngfAPI.ProxyBuffering, fieldP
 	return allErrs
 }
 
-// parseNginxSize parses an NGINX size string (e.g., "8k", "16m", "1024") and returns the size in bytes.
+// ParseNginxSize parses an NGINX size string (e.g., "8k", "16m", "1024") and returns the size in bytes.
 // Returns an error if the size string is invalid.
-func parseNginxSize(size string) (int64, error) {
+func ParseNginxSize(size string) (int64, error) {
 	size = strings.TrimSpace(strings.ToLower(size))
 	if size == "" {
 		return 0, strconv.ErrSyntax

internal/controller/nginx/config/policies/proxysettings/validator_test.go

@@ -310,3 +310,77 @@ func TestValidator_ConflictsPanics(t *testing.T) {
 
 	g.Expect(conflicts).To(Panic())
 }
+
+func TestParseNginxSize(t *testing.T) {
+	t.Parallel()
+	tests := []struct {
+		name          string
+		input         string
+		expectedBytes int64
+		expectError   bool
+	}{
+		{
+			name:          "bytes without unit",
+			input:         "1024",
+			expectedBytes: 1024,
+			expectError:   false,
+		},
+		{
+			name:          "kilobytes",
+			input:         "8k",
+			expectedBytes: 8 * 1024,
+			expectError:   false,
+		},
+		{
+			name:          "megabytes",
+			input:         "16m",
+			expectedBytes: 16 * 1024 * 1024,
+			expectError:   false,
+		},
+		{
+			name:          "gigabytes",
+			input:         "2g",
+			expectedBytes: 2 * 1024 * 1024 * 1024,
+			expectError:   false,
+		},
+		{
+			name:          "single digit",
+			input:         "4",
+			expectedBytes: 4,
+			expectError:   false,
+		},
+		{
+			name:          "four digits maximum",
+			input:         "9999",
+			expectedBytes: 9999,
+			expectError:   false,
+		},
+		{
+			name:          "four digits with unit",
+			input:         "1024k",
+			expectedBytes: 1024 * 1024,
+			expectError:   false,
+		},
+		{
+			name:        "invalid input - non-numeric",
+			input:       "abc",
+			expectError: true,
+		},
+	}
+
+	for _, test := range tests {
+		t.Run(test.name, func(t *testing.T) {
+			t.Parallel()
+			g := NewWithT(t)
+
+			result, err := proxysettings.ParseNginxSize(test.input)
+
+			if test.expectError {
+				g.Expect(err).To(HaveOccurred())
+			} else {
+				g.Expect(err).ToNot(HaveOccurred())
+				g.Expect(result).To(Equal(test.expectedBytes))
+			}
+		})
+	}
+}