Code review

Author: sjberman

build/Dockerfile.nginx

@@ -1,4 +1,5 @@
 # syntax=docker/dockerfile:1.12
+# TODO(sberman): the commented out lines are for when we use the published agent release
 # FROM scratch AS nginx-files
 
 # # the following links can be replaced with local files if needed, i.e. ADD --chown=101:1001 <local_file> <container_file>

internal/mode/static/nginx/agent/grpc.go

@@ -12,6 +12,11 @@ import (
 	"sigs.k8s.io/controller-runtime/pkg/manager"
 )
 
+const (
+	keepAliveTime    = 1 * time.Minute
+	keepAliveTimeout = 15 * time.Second
+)
+
 // GRPCServer is a gRPC server for communicating with the nginx agent.
 type GRPCServer struct {
 	Logger logr.Logger
@@ -32,8 +37,8 @@ func (g *GRPCServer) Start(ctx context.Context) error {
 	server := grpc.NewServer(
 		grpc.KeepaliveParams(
 			keepalive.ServerParameters{
-				Time:    1 * time.Minute,
-				Timeout: 15 * time.Second,
+				Time:    keepAliveTime,
+				Timeout: keepAliveTimeout,
 			},
 		),
 	)