fix data race condition

Author: salonichf5

cmd/gateway/commands.go

@@ -44,12 +44,6 @@ const (
 	endpointPickerEnableSecureVerifyFlag = "endpoint-picker-enable-secure-verify"
 )
 
-// common flags.
-var (
-	endpointPickerDisableTLS         bool
-	endpointPickerEnableSecureVerify bool
-)
-
 // usageReportParams holds the parameters for building the usage report configuration for PLUS.
 type usageReportParams struct {
 	SecretName           stringValidatingValue
@@ -170,6 +164,9 @@ func createControllerCommand() *cobra.Command {
 		nginxDockerSecrets = stringSliceValidatingValue{
 			validator: validateResourceName,
 		}
+
+		endpointPickerDisableTLS         bool
+		endpointPickerEnableSecureVerify bool
 	)
 
 	usageReportParams := usageReportParams{
@@ -451,7 +448,7 @@ func createControllerCommand() *cobra.Command {
 			"traffic to AI workloads.",
 	)
 
-	addEPPConnectionFlags(cmd)
+	addEPPConnectionFlags(cmd, endpointPickerDisableTLS, endpointPickerEnableSecureVerify)
 
 	cmd.Flags().Var(
 		&nginxDockerSecrets,
@@ -770,6 +767,7 @@ func createSleepCommand() *cobra.Command {
 }
 
 func createEndpointPickerCommand() *cobra.Command {
+	var endpointPickerDisableTLS, endpointPickerEnableSecureVerify bool
 	cmd := &cobra.Command{
 		Use:   "endpoint-picker",
 		Short: "Shim server for communication between NGINX and the Gateway API Inference Extension Endpoint Picker",
@@ -783,22 +781,22 @@ func createEndpointPickerCommand() *cobra.Command {
 		},
 	}
 
-	addEPPConnectionFlags(cmd)
+	addEPPConnectionFlags(cmd, endpointPickerDisableTLS, endpointPickerEnableSecureVerify)
 
 	return cmd
 }
 
-func addEPPConnectionFlags(cmd *cobra.Command) {
+func addEPPConnectionFlags(cmd *cobra.Command, disableTLS, enableSecureVerify bool) {
 	cmd.Flags().BoolVar(
-		&endpointPickerDisableTLS,
+		&disableTLS,
 		endpointPickerDisableTLSFlag,
 		false,
 		"Disables TLS when connecting to the EndpointPicker. "+
 			"Set to true only for development/testing or when using a service mesh for encryption.",
 	)
 
 	cmd.Flags().BoolVar(
-		&endpointPickerEnableSecureVerify,
+		&enableSecureVerify,
 		endpointPickerEnableSecureVerifyFlag,
 		false,
 		"Enables server certificate verification when connecting to the EndpointPicker, if TLS is enabled. "+