Skip to content

Commit 736dfe5

Browse files
committed
remove extra var assignment
1 parent 2b2a2b6 commit 736dfe5

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

internal/controller/state/graph/backend_tls_policy.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,7 @@ func addPolicyAncestorLimitCondition(
206206

207207
newCondition := conditions.NewPolicyAncestorLimitReached()
208208
newCondition.Message = fmt.Sprintf("%s %s %s", newCondition.Message, policyType, policyName)
209-
conds = append(conds, newCondition)
210-
return conds
209+
return append(conds, newCondition)
211210
}
212211

213212
// collectOrderedGateways collects gateways in spec order (services) then creation time order (gateways within service).
@@ -254,8 +253,7 @@ func collectOrderedGateways(
254253
sortGatewaysByCreationTime(existingGateways, gateways)
255254
sortGatewaysByCreationTime(newGateways, gateways)
256255

257-
existingGateways = append(existingGateways, newGateways...)
258-
return existingGateways
256+
return append(existingGateways, newGateways...)
259257
}
260258

261259
func extractExistingNGFGatewayAncestors(

internal/controller/state/graph/policies.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,7 @@ func collectOrderedGatewaysForService(
113113
sortGatewaysByCreationTime(existingGateways, gateways)
114114
sortGatewaysByCreationTime(newGateways, gateways)
115115

116-
existingGateways = append(existingGateways, newGateways...)
117-
return existingGateways
116+
return append(existingGateways, newGateways...)
118117
}
119118

120119
func (g *Graph) attachPolicies(validator validation.PolicyValidator, ctlrName string, logger logr.Logger) {

0 commit comments

Comments
 (0)