Add one more log

Author: sjberman

internal/controller/nginx/agent/agent.go

@@ -88,7 +88,7 @@ func (n *NginxUpdaterImpl) UpdateConfig(
 	deployment *Deployment,
 	files []File,
 ) {
-	msg := deployment.SetFiles(files)
+	msg := deployment.SetFiles(files, n.logger)
 	if msg == nil {
 		return
 	}

internal/controller/nginx/agent/agent_test.go

@@ -104,7 +104,7 @@ func TestUpdateConfig_NoChange(t *testing.T) {
 	}
 
 	// Set the initial files on the deployment
-	deployment.SetFiles([]File{file})
+	deployment.SetFiles([]File{file}, updater.logger)
 
 	// Call UpdateConfig with the same files
 	updater.UpdateConfig(deployment, []File{file})

internal/controller/nginx/agent/command_test.go

@@ -328,7 +328,7 @@ func TestSubscribe(t *testing.T) {
 			Contents: []byte("file contents"),
 		},
 	}
-	deployment.SetFiles(files)
+	deployment.SetFiles(files, logr.Discard())
 
 	initialAction := &pb.NGINXPlusAction{
 		Action: &pb.NGINXPlusAction_UpdateHttpUpstreamServers{},
@@ -457,7 +457,7 @@ func TestSubscribe_Reset(t *testing.T) {
 			Contents: []byte("file contents"),
 		},
 	}
-	deployment.SetFiles(files)
+	deployment.SetFiles(files, logr.Discard())
 
 	ctx, cancel := createGrpcContextWithCancel()
 	defer cancel()

internal/controller/nginx/agent/deployment.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"sync"
 
+	"github.com/go-logr/logr"
 	pb "github.com/nginx/agent/v3/api/grpc/mpi/v1"
 	filesHelper "github.com/nginx/agent/v3/pkg/files"
 	"k8s.io/apimachinery/pkg/types"
@@ -173,7 +174,7 @@ func (d *Deployment) GetFile(name, hash string) []byte {
 
 // SetFiles updates the nginx files and fileOverviews for the deployment and returns the message to send.
 // The deployment FileLock MUST already be locked before calling this function.
-func (d *Deployment) SetFiles(files []File) *broadcast.NginxAgentMessage {
+func (d *Deployment) SetFiles(files []File, logger logr.Logger) *broadcast.NginxAgentMessage {
 	d.files = files
 
 	fileOverviews := make([]*pb.File, 0, len(files))
@@ -197,6 +198,7 @@ func (d *Deployment) SetFiles(files []File) *broadcast.NginxAgentMessage {
 	newConfigVersion := filesHelper.GenerateConfigVersion(fileOverviews)
 	if d.configVersion == newConfigVersion {
 		// files have not changed, nothing to send
+		logger.V(1).Info("No changes to nginx configuration files, not sending to agent")
 		return nil
 	}
 

internal/controller/nginx/agent/deployment_test.go

@@ -5,6 +5,7 @@ import (
 	"errors"
 	"testing"
 
+	"github.com/go-logr/logr"
 	pb "github.com/nginx/agent/v3/api/grpc/mpi/v1"
 	. "github.com/onsi/gomega"
 	"k8s.io/apimachinery/pkg/types"
@@ -44,7 +45,7 @@ func TestSetAndGetFiles(t *testing.T) {
 		},
 	}
 
-	msg := deployment.SetFiles(files)
+	msg := deployment.SetFiles(files, logr.Discard())
 	fileOverviews, configVersion := deployment.GetFileOverviews()
 
 	g.Expect(msg.Type).To(Equal(broadcast.ConfigApplyRequest))
@@ -59,7 +60,7 @@ func TestSetAndGetFiles(t *testing.T) {
 	g.Expect(deployment.GetFile("test.conf", "invalid")).To(BeNil())
 
 	// Set the same files again
-	msg = deployment.SetFiles(files)
+	msg = deployment.SetFiles(files, logr.Discard())
 	g.Expect(msg).To(BeNil())
 
 	newFileOverviews, _ := deployment.GetFileOverviews()