updates based on reviews

Author: salonichf5

internal/mode/static/state/graph/route_common.go

@@ -420,10 +420,12 @@ func isolateHostnamesForParentRefs(parentRef []ParentRef, listenerHostnameMap ma
 						continue
 					}
 
-					// for L4Routes, we only compare the hostname and listener name combination
-					// because we do not allow l4Routes to attach to the same listener
-					// if they share the same port and hostname.
+					// for L7Routes, we compare the hostname, port and listener name combination
+					// to identify if hostname needs to be isolated.
 					if h == lHostPort.hostname && listenerName != lName {
+						// for L4Routes, we only compare the hostname and listener name combination
+						// because we do not allow l4Routes to attach to the same listener
+						// if they share the same port and hostname.
 						if isL4Route || lHostPort.port == ref.Attachment.ListenerPort {
 							hostnamesToRemoves[h] = struct{}{}
 						}

internal/mode/static/state/graph/route_common_test.go

@@ -2444,6 +2444,8 @@ func TestIsolateL4Listeners(t *testing.T) {
 		"tls_flavor": {"flavor.example.com"},
 	}
 
+	hostnamesNoSectionName := []gatewayv1.Hostname{"tea.example.com", "coffee.example.com", "flavor.example.com"}
+
 	tests := []struct {
 		expectedResult map[string][]ParentRef
 		listenerMap    map[string]hostPort
@@ -2462,21 +2464,21 @@ func TestIsolateL4Listeners(t *testing.T) {
 				createL4RoutewithAcceptedHostnames(
 					tlsCoffeeRoute,
 					acceptedHostnamesNoSectionName,
-					[]gatewayv1.Hostname{"coffee.example.com"},
+					hostnamesNoSectionName,
 					nil, // no section name
 					443,
 				),
 				createL4RoutewithAcceptedHostnames(
 					tlsTeaRoute,
 					acceptedHostnamesNoSectionName,
-					[]gatewayv1.Hostname{"tea.example.com"},
+					hostnamesNoSectionName,
 					nil, // no section name
 					443,
 				),
 				createL4RoutewithAcceptedHostnames(
 					tlsFlavorRoute,
 					acceptedHostnamesNoSectionName,
-					[]gatewayv1.Hostname{"flavor.example.com"},
+					hostnamesNoSectionName,
 					nil, // no section name
 					443,
 				),
@@ -2834,6 +2836,8 @@ func TestIsolateL7Listeners(t *testing.T) {
 		"hr_flavor": {"flavor.example.com"},
 	}
 
+	hostnamesNoSectionName := []gatewayv1.Hostname{"tea.example.com", "coffee.example.com", "flavor.example.com"}
+
 	tests := []struct {
 		expectedResult map[string][]ParentRef
 		listenersMap   map[string]hostPort
@@ -2884,21 +2888,21 @@ func TestIsolateL7Listeners(t *testing.T) {
 				createL7RoutewithAcceptedHostnames(
 					hrCoffeeRoute,
 					acceptedHostnamesNoSectionName,
-					[]gatewayv1.Hostname{"coffee.example.com"},
+					hostnamesNoSectionName,
 					nil, // no section name
 					80,
 				),
 				createL7RoutewithAcceptedHostnames(
 					hrTeaRoute,
 					acceptedHostnamesNoSectionName,
-					[]gatewayv1.Hostname{"tea.example.com"},
+					hostnamesNoSectionName,
 					nil, // no section name
 					80,
 				),
 				createL7RoutewithAcceptedHostnames(
 					hrFlavorRoute,
 					acceptedHostnamesNoSectionName,
-					[]gatewayv1.Hostname{"flavor.example.com"},
+					hostnamesNoSectionName,
 					nil, // no section name
 					80,
 				),