update unit tests and schema

Author: salonichf5

charts/nginx-gateway-fabric/values.schema.json

@@ -352,7 +352,7 @@
               "type": "object"
             },
             "readinessProbe": {
-              "description": "# Defines the settings for the data plane readiness probe. This probe returns Ready when the NGINX data plane is ready to serve traffic.",
+              "description": "# -- Defines the settings for the data plane readiness probe. This probe returns Ready when the NGINX data plane is ready to serve traffic.",
               "required": [],
               "title": "readinessProbe",
               "type": "object"

charts/nginx-gateway-fabric/values.yaml

@@ -441,7 +441,7 @@ nginx:
     # -- volumeMounts are the additional volume mounts for the NGINX container.
     volumeMounts: []
 
-    ## Defines the settings for the data plane readiness probe. This probe returns Ready when the NGINX data plane is ready to serve traffic.
+    ## -- Defines the settings for the data plane readiness probe. This probe returns Ready when the NGINX data plane is ready to serve traffic.
     readinessProbe: {}
       # @schema
       # type: integer

internal/controller/provisioner/objects_test.go

@@ -1071,7 +1071,6 @@ func TestBuildNginxConfigMaps_WorkerConnections(t *testing.T) {
 
 func TestBuildReadinessProbe(t *testing.T) {
 	t.Parallel()
-	g := NewWithT(t)
 
 	defaultProbe := &corev1.Probe{
 		ProbeHandler: corev1.ProbeHandler{
@@ -1104,15 +1103,6 @@ func TestBuildReadinessProbe(t *testing.T) {
 			},
 			expected: defaultProbe,
 		},
-		{
-			name: "daemonSet is nil, default probe is returned",
-			nProxyCfg: &graph.EffectiveNginxProxy{
-				Kubernetes: &ngfAPIv1alpha2.KubernetesSpec{
-					DaemonSet: nil,
-				},
-			},
-			expected: defaultProbe,
-		},
 		{
 			name: "container is nil, default probe is returned",
 			nProxyCfg: &graph.EffectiveNginxProxy{
@@ -1166,6 +1156,7 @@ func TestBuildReadinessProbe(t *testing.T) {
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
+			g := NewWithT(t)
 			probe := provisioner.buildReadinessProbe(tt.nProxyCfg)
 			g.Expect(probe).To(Equal(tt.expected))
 		})