update based on review

Author: salonichf5

internal/controller/manager.go

@@ -291,7 +291,7 @@ func StartManager(cfg config.Config) error {
 			},
 			ImageSource:               cfg.ImageSource,
 			Flags:                     cfg.Flags,
-			NginxOneConsoleSecretName: cfg.NginxOneConsoleTelemetryConfig.DataplaneKeySecretName,
+			NginxOneConsoleConnection: cfg.NginxOneConsoleTelemetryConfig.DataplaneKeySecretName != "",
 		})
 
 		job, err := createTelemetryJob(cfg, dataCollector, healthChecker.getReadyCh())

internal/controller/telemetry/collector.go

@@ -109,14 +109,22 @@ type NGFResourceCounts struct {
 
 // DataCollectorConfig holds configuration parameters for DataCollectorImpl.
 type DataCollectorConfig struct {
-	K8sClientReader           client.Reader
-	GraphGetter               GraphGetter
-	ConfigurationGetter       ConfigurationGetter
-	PodNSName                 types.NamespacedName
-	Version                   string
-	ImageSource               string
-	NginxOneConsoleSecretName string
-	Flags                     config.Flags
+	// K8sClientReader is a Kubernetes API client Reader.
+	K8sClientReader client.Reader
+	// GraphGetter allows us to get the Graph.
+	GraphGetter GraphGetter
+	// ConfigurationGetter allows us to get the Configuration.
+	ConfigurationGetter ConfigurationGetter
+	// PodNSName is the NamespacedName of the NGF Pod.
+	PodNSName types.NamespacedName
+	// Version is the NGF version.
+	Version string
+	// ImageSource is the source of the NGF image.
+	ImageSource string
+	// Flags contains the command-line NGF flag keys and values.
+	Flags config.Flags
+	// NginxOneConsoleConnection is a boolean that indicates whether the connection to the Nginx One Console is enabled.
+	NginxOneConsoleConnection bool
 }
 
 // DataCollectorImpl is am implementation of DataCollector.
@@ -185,7 +193,7 @@ func (c DataCollectorImpl) Collect(ctx context.Context) (Data, error) {
 		SnippetsFiltersDirectivesCount: snippetsFiltersDirectivesCount,
 		NginxPodCount:                  nginxPodCount,
 		ControlPlanePodCount:           int64(replicaCount),
-		NginxOneConnectionEnabled:      c.cfg.NginxOneConsoleSecretName != "",
+		NginxOneConnectionEnabled:      c.cfg.NginxOneConsoleConnection,
 	}
 
 	return data, nil

internal/controller/telemetry/collector_test.go

@@ -194,7 +194,7 @@ var _ = Describe("Collector", Ordered, func() {
 			PodNSName:                 podNSName,
 			ImageSource:               "local",
 			Flags:                     flags,
-			NginxOneConsoleSecretName: "nginx-one-console-secret",
+			NginxOneConsoleConnection: true,
 		})
 
 		baseGetCalls = createGetCallsFunc(ngfPod, ngfReplicaSet, kubeNamespace)