Move expected error strings to common.go

Author: shaun-nx

tests/cel/common.go

@@ -31,9 +31,11 @@ const (
 )
 
 const (
-	expectedTargetRefKindError       = `TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute`
-	expectedTargetRefGroupError      = `TargetRef Group must be gateway.networking.k8s.io.`
-	expectedHeaderWithoutServerError = `header can only be specified if server is specified`
+	expectedTargetRefKindError              = `TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute`
+	expectedTargetRefGroupError             = `TargetRef Group must be gateway.networking.k8s.io.`
+	expectedHeaderWithoutServerError        = `header can only be specified if server is specified`
+	expectedOneOfDeploymentOrDaemonSetError = `only one of deployment or daemonSet can be set`
+	expectedIfModeSetTrustedAddressesError  = `if mode is set, trustedAddresses is a required field`
 )
 
 const (

tests/cel/nginxproxy_test.go

@@ -24,23 +24,19 @@ func TestNginxProxyKubernetes(t *testing.T) {
 	}{
 		{
 			name:       "Validate NginxProxy with both Deployment and DaemonSet is invalid",
-			wantErrors: []string{"only one of deployment or daemonSet can be set"},
+			wantErrors: []string{expectedOneOfDeploymentOrDaemonSetError},
 			policySpec: ngfAPIv1alpha2.NginxProxySpec{
 				Kubernetes: &ngfAPIv1alpha2.KubernetesSpec{
-					Deployment: &ngfAPIv1alpha2.DeploymentSpec{
-						Replicas: helpers.GetPointer[int32](3),
-					},
-					DaemonSet: &ngfAPIv1alpha2.DaemonSetSpec{},
+					Deployment: &ngfAPIv1alpha2.DeploymentSpec{},
+					DaemonSet:  &ngfAPIv1alpha2.DaemonSetSpec{},
 				},
 			},
 		},
 		{
 			name: "Validate NginxProxy with Deployment only is valid",
 			policySpec: ngfAPIv1alpha2.NginxProxySpec{
 				Kubernetes: &ngfAPIv1alpha2.KubernetesSpec{
-					Deployment: &ngfAPIv1alpha2.DeploymentSpec{
-						Replicas: helpers.GetPointer[int32](3),
-					},
+					Deployment: &ngfAPIv1alpha2.DeploymentSpec{},
 				},
 			},
 		},
@@ -86,7 +82,7 @@ func TestNginxProxyRewriteClientIP(t *testing.T) {
 	}{
 		{
 			name:       "Validate NginxProxy is invalid when trustedAddresses is not set and mode is set",
-			wantErrors: []string{"if mode is set, trustedAddresses is a required field"},
+			wantErrors: []string{expectedIfModeSetTrustedAddressesError},
 			policySpec: ngfAPIv1alpha2.NginxProxySpec{
 				RewriteClientIP: &ngfAPIv1alpha2.RewriteClientIP{
 					Mode: helpers.GetPointer[ngfAPIv1alpha2.RewriteClientIPModeType]("XForwardedFor"),