Allow for provisioning NGINX as DaemonSet (#3397)

Problem: With the initial provisioner implementation, the NGINX gateway could only be installed as a Deployment. Users may want to install NGINX as a DaemonSet.

Solution: Allow for provisioning the NGINX gateway as a DaemonSet.

Author: sjberman

apis/v1alpha2/nginxproxy_types.go

@@ -359,13 +359,22 @@ const (
 )
 
 // KubernetesSpec contains the configuration for the NGINX Deployment and Service Kubernetes objects.
+//
+// +kubebuilder:validation:XValidation:message="only one of deployment or daemonSet can be set",rule="(!has(self.deployment) && !has(self.daemonSet)) || ((has(self.deployment) && !has(self.daemonSet)) || (!has(self.deployment) && has(self.daemonSet)))"
+//
+//nolint:lll
 type KubernetesSpec struct {
 	// Deployment is the configuration for the NGINX Deployment.
 	// This is the default deployment option.
 	//
 	// +optional
 	Deployment *DeploymentSpec `json:"deployment,omitempty"`
 
+	// DaemonSet is the configuration for the NGINX DaemonSet.
+	//
+	// +optional
+	DaemonSet *DaemonSetSpec `json:"daemonSet,omitempty"`
+
 	// Service is the configuration for the NGINX Service.
 	//
 	// +optional
@@ -382,12 +391,25 @@ type DeploymentSpec struct {
 	// Pod defines Pod-specific fields.
 	//
 	// +optional
-	Pod PodSpec `json:"pod,omitempty"`
+	Pod PodSpec `json:"pod"`
+
+	// Container defines container fields for the NGINX container.
+	//
+	// +optional
+	Container ContainerSpec `json:"container"`
+}
+
+// DaemonSet is the configuration for the NGINX DaemonSet.
+type DaemonSetSpec struct {
+	// Pod defines Pod-specific fields.
+	//
+	// +optional
+	Pod PodSpec `json:"pod"`
 
 	// Container defines container fields for the NGINX container.
 	//
 	// +optional
-	Container ContainerSpec `json:"container,omitempty"`
+	Container ContainerSpec `json:"container"`
 }
 
 // PodSpec defines Pod-specific fields.

apis/v1alpha2/zz_generated.deepcopy.go

@@ -14,6 +14,7 @@ rules:
   - serviceaccounts
   - services
   - deployments
+  - daemonsets
   verbs:
   - create
   - update

charts/nginx-gateway-fabric/templates/clusterrole.yaml

@@ -27,6 +27,22 @@ spec:
         debug: {{ .Values.nginx.debug }}
         {{- end }}
     {{- end }}
+    {{- if eq .Values.nginx.kind "daemonSet" }}
+    daemonSet:
+      {{- if .Values.nginx.pod }}
+      pod:
+        {{- toYaml .Values.nginx.pod | nindent 8 }}
+      {{- end }}
+      container:
+        {{- if .Values.nginx.container }}
+          {{- toYaml .Values.nginx.container | nindent 8 }}
+        {{- end }}
+        image:
+          {{- toYaml .Values.nginx.image | nindent 10 }}
+        {{- if .Values.nginx.debug }}
+        debug: {{ .Values.nginx.debug }}
+        {{- end }}
+    {{- end }}
     {{- if .Values.nginx.service }}
     service:
       {{- with .Values.nginx.service }}

charts/nginx-gateway-fabric/templates/nginxproxy.yaml

@@ -337,7 +337,8 @@
           "default": "deployment",
           "description": "The kind of NGINX deployment.",
           "enum": [
-            "deployment"
+            "deployment",
+            "daemonSet"
           ],
           "required": [],
           "title": "kind"

charts/nginx-gateway-fabric/values.schema.json

@@ -185,6 +185,7 @@ nginx:
   # @schema
   # enum:
   #   - deployment
+  #   - daemonSet
   # @schema
   # -- The kind of NGINX deployment.
   kind: deployment

charts/nginx-gateway-fabric/values.yaml

@@ -60,6 +60,7 @@ rules:
   - serviceaccounts
   - services
   - deployments
+  - daemonsets
   verbs:
   - create
   - update

config/crd/bases/gateway.nginx.org_nginxproxies.yaml

@@ -60,6 +60,7 @@ rules:
   - serviceaccounts
   - services
   - deployments
+  - daemonsets
   verbs:
   - create
   - update