Skip to content

Commit b916e8c

Browse files
author
Kate Osborn
committed
Add more test coverage
1 parent 3d25776 commit b916e8c

File tree

1 file changed

+51
-0
lines changed

1 file changed

+51
-0
lines changed

internal/mode/static/state/dataplane/configuration_test.go

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3256,6 +3256,11 @@ func TestBuildTelemetry(t *testing.T) {
32563256
msg string
32573257
expTelemetry Telemetry
32583258
}{
3259+
{
3260+
g: &graph.Graph{},
3261+
expTelemetry: Telemetry{},
3262+
msg: "nil Gateway",
3263+
},
32593264
{
32603265
g: &graph.Graph{
32613266
Gateway: &graph.Gateway{
@@ -3274,6 +3279,52 @@ func TestBuildTelemetry(t *testing.T) {
32743279
expTelemetry: Telemetry{},
32753280
msg: "No telemetry configured",
32763281
},
3282+
{
3283+
g: &graph.Graph{
3284+
Gateway: &graph.Gateway{
3285+
EffectiveNginxProxy: &graph.EffectiveNginxProxy{
3286+
Telemetry: &ngfAPIv1alpha2.Telemetry{
3287+
Exporter: &ngfAPIv1alpha2.TelemetryExporter{
3288+
Endpoint: helpers.GetPointer("my-otel.svc:4563"),
3289+
},
3290+
DisabledFeatures: []ngfAPIv1alpha2.DisableTelemetryFeature{
3291+
ngfAPIv1alpha2.DisableTracing,
3292+
},
3293+
},
3294+
},
3295+
},
3296+
},
3297+
expTelemetry: Telemetry{},
3298+
msg: "Telemetry disabled explicitly",
3299+
},
3300+
{
3301+
g: &graph.Graph{
3302+
Gateway: &graph.Gateway{
3303+
EffectiveNginxProxy: &graph.EffectiveNginxProxy{
3304+
Telemetry: &ngfAPIv1alpha2.Telemetry{
3305+
Exporter: nil,
3306+
},
3307+
},
3308+
},
3309+
},
3310+
expTelemetry: Telemetry{},
3311+
msg: "Telemetry disabled implicitly (nil exporter)",
3312+
},
3313+
{
3314+
g: &graph.Graph{
3315+
Gateway: &graph.Gateway{
3316+
EffectiveNginxProxy: &graph.EffectiveNginxProxy{
3317+
Telemetry: &ngfAPIv1alpha2.Telemetry{
3318+
Exporter: &ngfAPIv1alpha2.TelemetryExporter{
3319+
Endpoint: nil,
3320+
},
3321+
},
3322+
},
3323+
},
3324+
},
3325+
expTelemetry: Telemetry{},
3326+
msg: "Telemetry disabled implicitly (nil exporter endpoint)",
3327+
},
32773328
{
32783329
g: &graph.Graph{
32793330
Gateway: &graph.Gateway{

0 commit comments

Comments
 (0)