Code Review

Author: nowjean

charts/nginx-gateway-fabric/templates/nginxproxy.yaml

@@ -18,10 +18,6 @@ spec:
       {{- if .Values.nginx.autoscaling.enabled }}
       autoscaling:
         enabled: {{ .Values.nginx.autoscaling.enabled }}
-        {{- if .Values.nginx.autoscaling.hpaAnnotations }}
-        hpaAnnotations:
-          {{- toYaml .Values.nginx.autoscaling.hpaAnnotations | nindent 10 }}
-        {{- end }}
         minReplicas: {{ .Values.nginx.autoscaling.minReplicas }}
         maxReplicas: {{ .Values.nginx.autoscaling.maxReplicas }}
         {{- if .Values.nginx.autoscaling.targetCPUUtilizationPercentage }}

charts/nginx-gateway-fabric/values.yaml

@@ -232,7 +232,6 @@ nginx:
   autoscaling:
     # Enable or disable Horizontal Pod Autoscaler
     enabled: false
-    # hpaAnnotations: {}
     # minReplicas: 1
     # maxReplicas: 11
     # targetCPUUtilizationPercentage: 50

config/crd/bases/gateway.nginx.org_nginxproxies.yaml

@@ -4181,6 +4181,7 @@ spec:
                             description: Enable or disable Horizontal Pod Autoscaler
                             type: boolean
 <<<<<<< HEAD
+<<<<<<< HEAD
 =======
                           hpaAnnotations:
                             additionalProperties:
@@ -4192,6 +4193,8 @@ spec:
                               queryable and should be preserved when modifying objects.
                               More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/annotations
                             type: object
+>>>>>>> Code Review
+=======
 >>>>>>> Code Review
                           maxReplicas:
                             description: Maximum number of replicas.

internal/controller/provisioner/eventloop.go

@@ -81,7 +81,6 @@ func newEventLoop(
 					k8spredicate.And(
 						k8spredicate.GenerationChangedPredicate{},
 						nginxResourceLabelPredicate,
-						predicate.RestartDeploymentAnnotationPredicate{},
 					),
 				),
 			},