Add tests for targetRefGroup

Author: shaun-nx

tests/cel/policies/clientsettingspolicies/targetRef_test.go

@@ -13,11 +13,16 @@ func TestClientSettingsPoliciesTargetRef(t *testing.T) {
 		"GRPCRoute": true,
 	}
 
-	testInvalidTargetRefs(t, allowedKinds)
 	testValidTargetRefs(t, allowedKinds)
+	testInvalidTargetRefs(t, allowedKinds)
 }
 
-func testInvalidTargetRefs(t *testing.T, allowedKinds map[string]bool) {
+func TestClientSettingsPoliciesTargetRefGroup(t *testing.T) {
+	testValidTargetRefGroup(t)
+	testInvalidTargetRefGroup(t)
+}
+
+func testValidTargetRefs(t *testing.T, allowedKinds map[string]bool) {
 	t.Helper()
 
 	tests := []struct {
@@ -29,15 +34,23 @@ func testInvalidTargetRefs(t *testing.T, allowedKinds map[string]bool) {
 			name:       "Validate TargetRef is of an allowed kind",
 			wantErrors: "TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute'",
 			targetRef: gatewayv1alpha2.LocalPolicyTargetReference{
-				Kind:  "InvalidKind",
+				Kind:  "Gateway",
 				Group: "gateway.networking.k8s.io",
 			},
 		},
 		{
 			name:       "Validate TargetRef is of an allowed kind",
 			wantErrors: "TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute'",
 			targetRef: gatewayv1alpha2.LocalPolicyTargetReference{
-				Kind:  "TCPRoute",
+				Kind:  "HTTPRoute",
+				Group: "gateway.networking.k8s.io",
+			},
+		},
+		{
+			name:       "Validate TargetRef is of an allowed kind",
+			wantErrors: "TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute'",
+			targetRef: gatewayv1alpha2.LocalPolicyTargetReference{
+				Kind:  "GRPCRoute",
 				Group: "gateway.networking.k8s.io",
 			},
 		},
@@ -48,15 +61,15 @@ func testInvalidTargetRefs(t *testing.T, allowedKinds map[string]bool) {
 			if _, ok := allowedKinds[string(tt.targetRef.Kind)]; !ok {
 				gotError := "TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute'"
 
-				if tt.wantErrors != gotError {
+				if tt.wantErrors == gotError {
 					t.Errorf("Test %s failed: got error %q, want %q", tt.name, gotError, tt.wantErrors)
 				}
 			}
 		})
 	}
 }
 
-func testValidTargetRefs(t *testing.T, allowedKinds map[string]bool) {
+func testInvalidTargetRefs(t *testing.T, allowedKinds map[string]bool) {
 	t.Helper()
 
 	tests := []struct {
@@ -68,32 +81,54 @@ func testValidTargetRefs(t *testing.T, allowedKinds map[string]bool) {
 			name:       "Validate TargetRef is of an allowed kind",
 			wantErrors: "TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute'",
 			targetRef: gatewayv1alpha2.LocalPolicyTargetReference{
-				Kind:  "Gateway",
+				Kind:  "InvalidKind",
 				Group: "gateway.networking.k8s.io",
 			},
 		},
 		{
 			name:       "Validate TargetRef is of an allowed kind",
 			wantErrors: "TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute'",
 			targetRef: gatewayv1alpha2.LocalPolicyTargetReference{
-				Kind:  "HTTPRoute",
+				Kind:  "TCPRoute",
 				Group: "gateway.networking.k8s.io",
 			},
 		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if _, ok := allowedKinds[string(tt.targetRef.Kind)]; !ok {
+				gotError := "TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute'"
+
+				if tt.wantErrors != gotError {
+					t.Errorf("Test %s failed: got error %q, want %q", tt.name, gotError, tt.wantErrors)
+				}
+			}
+		})
+	}
+}
+
+func testValidTargetRefGroup(t *testing.T) {
+	t.Helper()
+
+	tests := []struct {
+		name           string
+		wantErrors     string
+		targetRefGroup gatewayv1alpha2.LocalPolicyTargetReference
+	}{
 		{
-			name:       "Validate TargetRef is of an allowed kind",
-			wantErrors: "TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute'",
-			targetRef: gatewayv1alpha2.LocalPolicyTargetReference{
-				Kind:  "GRPCRoute",
+			name:       "Validate TargetRef group is gateway.networking.k8s.io",
+			wantErrors: "TargetRef Group must be gateway.networking.k8s.io",
+			targetRefGroup: gatewayv1alpha2.LocalPolicyTargetReference{
 				Group: "gateway.networking.k8s.io",
 			},
 		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			if _, ok := allowedKinds[string(tt.targetRef.Kind)]; !ok {
-				gotError := "TargetRef Kind must be one of: Gateway, HTTPRoute, or GRPCRoute'"
+			if tt.targetRefGroup.Group != "gateway.networking.k8s.io" {
+				gotError := "TargetRef Group must be gateway.networking.k8s.io"
 
 				if tt.wantErrors == gotError {
 					t.Errorf("Test %s failed: got error %q, want %q", tt.name, gotError, tt.wantErrors)
@@ -102,3 +137,40 @@ func testValidTargetRefs(t *testing.T, allowedKinds map[string]bool) {
 		})
 	}
 }
+
+func testInvalidTargetRefGroup(t *testing.T) {
+	t.Helper()
+
+	tests := []struct {
+		name           string
+		wantErrors     string
+		targetRefGroup gatewayv1alpha2.LocalPolicyTargetReference
+	}{
+		{
+			name:       "Validate TargetRef group is gateway.networking.k8s.io",
+			wantErrors: "TargetRef Group must be gateway.networking.k8s.io",
+			targetRefGroup: gatewayv1alpha2.LocalPolicyTargetReference{
+				Group: "invalid.networking.k8s.io",
+			},
+		},
+		{
+			name:       "Validate TargetRef is of an allowed kind",
+			wantErrors: "TargetRef Group must be gateway.networking.k8s.io",
+			targetRefGroup: gatewayv1alpha2.LocalPolicyTargetReference{
+				Group: "discovery.k8s.io/v1",
+			},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if tt.targetRefGroup.Group != "gateway.networking.k8s.io" {
+				gotError := "TargetRef Group must be gateway.networking.k8s.io"
+
+				if tt.wantErrors != gotError {
+					t.Errorf("Test %s failed: got error %q, want %q", tt.name, gotError, tt.wantErrors)
+				}
+			}
+		})
+	}
+}