Fix naming conventions, test messages, and add more comments

Author: bjee19

internal/mode/static/nginx/config/policies/processor.go

@@ -1,15 +1,21 @@
 package policies
 
-// UpstreamSettingsProcessor defines an interface for an UpstreamSettingsPolicy to implement the process function.
+// UpstreamSettingsProcessor defines an interface for an UpstreamSettingsPolicy processor'
+// to implement the process function.
 type UpstreamSettingsProcessor interface {
 	Process(policies []Policy) UpstreamSettings
 }
 
 // UpstreamSettings contains settings from UpstreamSettingsPolicy.
 type UpstreamSettings struct {
-	ZoneSize             string
-	KeepAliveTime        string
-	KeepAliveTimeout     string
+	// ZoneSize is the zone size setting.
+	ZoneSize string
+	// KeepAliveTime is the keep-alive time setting.
+	KeepAliveTime string
+	// KeepAliveTimeout is the keep-alive timeout setting.
+	KeepAliveTimeout string
+	// KeepAliveConnections is the keep-alive connections setting.
 	KeepAliveConnections int32
-	KeepAliveRequests    int32
+	// KeepAliveRequests is the keep-alive requests setting.
+	KeepAliveRequests int32
 }

internal/mode/static/nginx/config/policies/upstreamsettings/processor_test.go

@@ -47,7 +47,7 @@ func TestProcess(t *testing.T) {
 			},
 		},
 		{
-			name: "zoneSize set",
+			name: "zone size set",
 			policies: []policies.Policy{
 				&ngfAPI.UpstreamSettingsPolicy{
 					ObjectMeta: metav1.ObjectMeta{
@@ -64,7 +64,7 @@ func TestProcess(t *testing.T) {
 			},
 		},
 		{
-			name: "keepAlive Connections set",
+			name: "keep alive connections set",
 			policies: []policies.Policy{
 				&ngfAPI.UpstreamSettingsPolicy{
 					ObjectMeta: metav1.ObjectMeta{
@@ -83,7 +83,7 @@ func TestProcess(t *testing.T) {
 			},
 		},
 		{
-			name: "keepAlive Requests set",
+			name: "keep alive requests set",
 			policies: []policies.Policy{
 				&ngfAPI.UpstreamSettingsPolicy{
 					ObjectMeta: metav1.ObjectMeta{
@@ -102,7 +102,7 @@ func TestProcess(t *testing.T) {
 			},
 		},
 		{
-			name: "keepAlive Time set",
+			name: "keep alive time set",
 			policies: []policies.Policy{
 				&ngfAPI.UpstreamSettingsPolicy{
 					ObjectMeta: metav1.ObjectMeta{
@@ -121,7 +121,7 @@ func TestProcess(t *testing.T) {
 			},
 		},
 		{
-			name: "keepAlive Timeout set",
+			name: "keep alive timeout set",
 			policies: []policies.Policy{
 				&ngfAPI.UpstreamSettingsPolicy{
 					ObjectMeta: metav1.ObjectMeta{

internal/mode/static/nginx/config/upstreams.go

@@ -123,13 +123,13 @@ func (g GeneratorImpl) createStreamUpstream(up dataplane.Upstream) stream.Upstre
 
 func (g GeneratorImpl) createUpstreams(
 	upstreams []dataplane.Upstream,
-	generator policies.UpstreamSettingsProcessor,
+	processor policies.UpstreamSettingsProcessor,
 ) []http.Upstream {
 	// capacity is the number of upstreams + 1 for the invalid backend ref upstream
 	ups := make([]http.Upstream, 0, len(upstreams)+1)
 
 	for _, u := range upstreams {
-		ups = append(ups, g.createUpstream(u, generator))
+		ups = append(ups, g.createUpstream(u, processor))
 	}
 
 	ups = append(ups, createInvalidBackendRefUpstream())
@@ -139,9 +139,9 @@ func (g GeneratorImpl) createUpstreams(
 
 func (g GeneratorImpl) createUpstream(
 	up dataplane.Upstream,
-	generator policies.UpstreamSettingsProcessor,
+	processor policies.UpstreamSettingsProcessor,
 ) http.Upstream {
-	upstreamPolicySettings := generator.Process(up.Policies)
+	upstreamPolicySettings := processor.Process(up.Policies)
 
 	zoneSize := ossZoneSize
 	if g.plus {